Skip to content

Conversation

@pinkhoodie
Copy link
Contributor

@pinkhoodie pinkhoodie commented Mar 5, 2025


PR-Codex overview

This PR focuses on implementing caching for the last used chain IDs in the ChatPageContent component. It adds functionality to store and retrieve these IDs from localStorage, enhancing user experience by remembering their last selections.

Detailed summary

  • Introduced NEBULA_LAST_USED_CHAIN_IDS_KEY constant for localStorage key.
  • Added logic to cache chain IDs in localStorage when context updates.
  • Implemented retrieval of cached chain IDs from localStorage.
  • Updated updatedContextFilters with cached chain IDs if available.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@pinkhoodie pinkhoodie requested review from a team as code owners March 5, 2025 17:55
@linear
Copy link

linear bot commented Mar 5, 2025

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2025

⚠️ No Changeset found

Latest commit: 1439975

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 5:53pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 5:53pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 5:53pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 5:53pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 5:53pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 293 ms (+126.66% 🔺) 1.3 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 388 ms (+18.41% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 94 ms (+753.55% 🔺) 206 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 28 ms (+732.53% 🔺) 38 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (+0.02% 🔺) 387 ms (+0.02% 🔺) 101 ms (+277.59% 🔺) 488 ms

@MananTank MananTank requested a review from jnsdls March 10, 2025 17:10
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 10, 2025 17:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 10, 2025 17:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 10, 2025 17:15 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 10, 2025 17:15 Inactive
@MananTank
Copy link
Member

Closing because commit signing issues - creating new PR for this

@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.73%. Comparing base (6911102) to head (1439975).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6420   +/-   ##
=======================================
  Coverage   54.73%   54.73%           
=======================================
  Files         874      874           
  Lines       54710    54710           
  Branches     3712     3712           
=======================================
  Hits        29946    29946           
  Misses      24669    24669           
  Partials       95       95           
Flag Coverage Δ
packages 54.73% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants