-
Notifications
You must be signed in to change notification settings - Fork 621
PRO-71 PRO-72 [Portal] Deprecate Permissions + Account Factories Pages #6423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6423 +/- ##
==========================================
+ Coverage 54.62% 54.73% +0.11%
==========================================
Files 874 874
Lines 54743 54710 -33
Branches 3711 3712 +1
==========================================
+ Hits 29902 29946 +44
+ Misses 24746 24669 -77
Partials 95 95
🚀 New features to boost your workflow:
|
size-limit report 📦
|
joaquim-verges
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we removing this pages? they're still relevant
|
This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs. |
|
@joaquim-verges if they are relevant then let's keep them. Was told we should remove. |
This PR implements the following changes:
1. Renamed
page.mdxto_page.mdxfor Account Factories and Permissions, effectively deprecating these pages.2. Removed sidebar navigation entries for:
• Account Factories under Account Abstraction
• Permissions under Extensions > General
These changes are part of the PRO-71 ticket, focusing on deprecating specific pages in the Portal section.
PR-Codex overview
This PR focuses on removing unused or outdated sections from the codebase, specifically related to account factories and permissions, while making minor text adjustments in the
README.md.Detailed summary
page.mdxfiles related to account factories and permissions.sidebar.tsx.README.mdto add a period at the end of a description sentence.contracts/sidebar.tsx.