Skip to content

Conversation

@pinkhoodie
Copy link
Contributor

@pinkhoodie pinkhoodie commented Mar 5, 2025

This PR implements the following changes:
1. Renamed page.mdx to _page.mdx for Account Factories and Permissions, effectively deprecating these pages.
2. Removed sidebar navigation entries for:
• Account Factories under Account Abstraction
• Permissions under Extensions > General

These changes are part of the PRO-71 ticket, focusing on deprecating specific pages in the Portal section.


PR-Codex overview

This PR focuses on removing unused or outdated sections from the codebase, specifically related to account factories and permissions, while making minor text adjustments in the README.md.

Detailed summary

  • Deleted page.mdx files related to account factories and permissions.
  • Removed the "Account Factories" entry from the sidebar in sidebar.tsx.
  • Updated the README.md to add a period at the end of a description sentence.
  • Removed the "Permissions" entry from the sidebar in contracts/sidebar.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@pinkhoodie pinkhoodie requested review from a team as code owners March 5, 2025 19:06
@linear
Copy link

linear bot commented Mar 5, 2025

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2025

⚠️ No Changeset found

Latest commit: 40741ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 5:23pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 5:23pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 5:23pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 5:23pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 5:23pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Mar 5, 2025
@pinkhoodie pinkhoodie changed the title PRO-71 [Portal] Deprecate Permissions + Account Factories Pages PRO-71 PRO-72 [Portal] Deprecate Permissions + Account Factories Pages Mar 5, 2025
@linear
Copy link

linear bot commented Mar 5, 2025

@codecov
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.73%. Comparing base (834ed83) to head (40741ec).
Report is 72 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6423      +/-   ##
==========================================
+ Coverage   54.62%   54.73%   +0.11%     
==========================================
  Files         874      874              
  Lines       54743    54710      -33     
  Branches     3711     3712       +1     
==========================================
+ Hits        29902    29946      +44     
+ Misses      24746    24669      -77     
  Partials       95       95              
Flag Coverage Δ
packages ∅ <ø> (∅)

see 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 191 ms (+105.88% 🔺) 1.2 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 328 ms (+39.47% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 88 ms (+1005.55% 🔺) 200 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 23 ms (+724.09% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 123 ms (+614.11% 🔺) 509 ms

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 6, 2025 11:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 6, 2025 11:58 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 6, 2025 11:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 6, 2025 11:58 Inactive
Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing this pages? they're still relevant

@github-actions
Copy link
Contributor

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Mar 18, 2025
@pinkhoodie
Copy link
Contributor Author

@joaquim-verges if they are relevant then let's keep them. Was told we should remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants