Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 6, 2025


PR-Codex overview

This PR focuses on allowing the customization of storage for wallet states in the thirdweb library, enhancing flexibility for in-app and ecosystem wallets.

Detailed summary

  • Introduced storage option for wallet state management in various wallet types.
  • Updated InAppWebConnector and InAppNativeConnector to use custom storage.
  • Added documentation on overriding storage in inAppWallet.
  • Enhanced type definitions to include storage parameter in wallet options.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 11:34pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 11:34pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 11:34pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 11:34pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 11:34pm

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: 1917273

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review March 6, 2025 22:43
@joaquim-verges joaquim-verges requested review from a team as code owners March 6, 2025 22:43
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 6, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 137 ms (+111.28% 🔺) 1.1 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 206 ms (+21.36% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 65 ms (+1205.93% 🔺) 177 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 19 ms (+856.36% 🔺) 29 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 43 ms (+199.96% 🔺) 430 ms

@joaquim-verges joaquim-verges deleted the _SDK_feat_Allow_custom_storage_for_inApp_and_ecosystem_wallets branch March 7, 2025 00:16
@joaquim-verges joaquim-verges mentioned this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants