Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 7, 2025


PR-Codex overview

This PR updates the testing for the smart wallet integration by switching the blockchain network from sepolia to arbitrumSepolia, modifies the contract address, and enhances the test assertions to ensure a contract is deployed.

Detailed summary

  • Added import for arbitrumSepolia.
  • Changed the chain variable from sepolia to arbitrumSepolia.
  • Updated contract address from 0xe2cb0eb5147b42095c2FfA6F7ec953bb0bE347D8 to 0x6A7a26c9a595E6893C255C9dF0b593e77518e0c3.
  • Added assertion to check if the contract is deployed.
  • Updated error message in the transaction rejection snapshot to reflect the new chain ID.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2025

⚠️ No Changeset found

Latest commit: efceadd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 8:46pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 8:46pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 8:46pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 8:46pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 8:46pm

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 7, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 362 ms (+203.21% 🔺) 1.3 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 446 ms (+69.69% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 110 ms (+453.42% 🔺) 222 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 24 ms (+691.76% 🔺) 34 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 78 ms (+224.86% 🔺) 465 ms

@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.64%. Comparing base (01d0666) to head (efceadd).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6436      +/-   ##
==========================================
+ Coverage   54.62%   54.64%   +0.02%     
==========================================
  Files         874      874              
  Lines       54743    54707      -36     
  Branches     3711     3709       -2     
==========================================
- Hits        29902    29897       -5     
+ Misses      24746    24716      -30     
+ Partials       95       94       -1     
Flag Coverage Δ
packages 54.64% <ø> (+0.02%) ⬆️

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 7, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the test file `smart-wallet-integration-v07.test.ts` to switch the blockchain network from `sepolia` to `arbitrumSepolia`, modifies the contract address, and adds a new expectation for contract deployment verification.

### Detailed summary
- Added import for `arbitrumSepolia`.
- Changed the blockchain network from `sepolia` to `arbitrumSepolia`.
- Updated the contract address from `0xe2cb0eb5147b42095c2FfA6F7ec953bb0bE347D8` to `0x6A7a26c9a595E6893C255C9dF0b593e77518e0c3`.
- Added expectation to verify if the contract is deployed.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants