fix: onramp improvements #6437
Merged
fix: onramp improvements #6437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0562302 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
Playground
jnsdls
approved these changes
Mar 7, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6437 +/- ##
==========================================
- Coverage 54.64% 54.63% -0.02%
==========================================
Files 874 874
Lines 54707 54708 +1
Branches 3709 3708 -1
==========================================
- Hits 29897 29892 -5
- Misses 24716 24722 +6
Partials 94 94
🚀 New features to boost your workflow:
|
packages/thirdweb/src/react/core/hooks/pay/useBuyWithCryptoQuote.ts
Outdated
Show resolved
Hide resolved
joaquim-verges
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving the onramp experience by enhancing the
OnRampScreenfunctionality and updating theuseBuyWithCryptoQuotehook to include a refetch interval.Detailed summary
OnRampScreen.tsx:swapQuoteQuery.refetch()toawait swapQuoteQuery.refetch().useBuyWithCryptoQuote.ts:refetchInterval: 20_000to the query parameters.