Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 10, 2025

Fixes #6444


PR-Codex overview

This PR focuses on enhancing the EIP1193 provider adapter by fixing transaction value filtering and improving the handling of transaction properties in the EnclaveWallet class.

Detailed summary

  • Fixed filtering of transaction values in to-eip1193 adapter.
  • Added waitForReceipt to validate transaction success in tests.
  • Updated EnclaveWallet to use hexlify for transaction properties.
  • Simplified gas and value handling in transaction records.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: f41378f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 7:05am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 7:05am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 7:05am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 7:05am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 7:05am

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 10, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 129 ms (+87.58% 🔺) 1.1 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 228 ms (+26.86% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 83 ms (+1142.96% 🔺) 195 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 21 ms (+1045.73% 🔺) 31 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 54 ms (+314.17% 🔺) 441 ms

@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

Project coverage is 54.73%. Comparing base (f7cf09b) to head (f41378f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...b/src/wallets/in-app/core/wallet/enclave-wallet.ts 4.76% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6449      +/-   ##
==========================================
+ Coverage   54.63%   54.73%   +0.09%     
==========================================
  Files         874      874              
  Lines       54714    54710       -4     
  Branches     3709     3714       +5     
==========================================
+ Hits        29895    29946      +51     
+ Misses      24724    24669      -55     
  Partials       95       95              
Flag Coverage Δ
packages 54.73% <4.76%> (+0.09%) ⬆️
Files with missing lines Coverage Δ
...b/src/wallets/in-app/core/wallet/enclave-wallet.ts 6.59% <4.76%> (+0.17%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit f655657 into main Mar 10, 2025
32 of 35 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_EIP1193_provider_value_filtering_in_transactions branch March 10, 2025 07:01
@joaquim-verges joaquim-verges mentioned this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thirdweb in-app wallet with wagmi (without smart account) always sends 0 value

2 participants