Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Mar 11, 2025

PR-Codex overview

This PR focuses on two main changes: correcting a typo in the console log message in wallet.ts and modifying the Code.tsx component to allow for whitespace preservation in the rendered code block.

Detailed summary

  • In wallet.ts, changed the console log message from "Walelt name" to "wallet name".
  • In Code.tsx, updated the className to include whitespace-pre for preserving whitespace in the code block.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Mar 11, 2025

@vercel
Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 5:34pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 5:34pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 5:34pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 5:34pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 5:34pm

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2025

⚠️ No Changeset found

Latest commit: 91194ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login March 11, 2025 11:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 11, 2025 11:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 11, 2025 11:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 11, 2025 11:14 Inactive
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Mar 11, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review March 11, 2025 11:14
@MananTank MananTank requested review from a team as code owners March 11, 2025 11:14
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.81%. Comparing base (a1141f3) to head (91194ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6461   +/-   ##
=======================================
  Coverage   54.81%   54.81%           
=======================================
  Files         875      875           
  Lines       54851    54851           
  Branches     3736     3735    -1     
=======================================
  Hits        30066    30066           
  Misses      24690    24690           
  Partials       95       95           
Flag Coverage Δ
packages 54.81% <ø> (ø)
Files with missing lines Coverage Δ
packages/thirdweb/src/react/core/utils/wallet.ts 40.90% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 217 ms (+145.64% 🔺) 1.2 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 354 ms (+48.36% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 136 ms (+1980.9% 🔺) 247 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 37 ms (+758.44% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 74 ms (+238.64% 🔺) 460 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 11, 2025

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on improving code readability and fixing a typo in the console log message, as well as adjusting the CSS class for better text formatting in a component.

### Detailed summary
- In `packages/thirdweb/src/react/core/utils/wallet.ts`, the console log message was changed from `"Walelt name"` to `"wallet name"` for clarity.
- In `apps/portal/src/components/Document/Code.tsx`, the CSS class was modified from `rounded-lg border bg-card font-mono text-sm leading-relaxed` to `whitespace-pre rounded-lg border bg-card font-mono text-sm leading-relaxed` to enhance text formatting.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants