Skip to content

[TOOL-3691] Dashbaord: Keep project settings submit button always enabled #6467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
+7 −12
Merged

[TOOL-3691] Dashbaord: Keep project settings submit button always enabled #6467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions ...dashboard/src/app/team/[team_slug]/[project_slug]/settings/ProjectGeneralSettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,6 @@ function ProjectNameSetting(props: {
handleSubmit: () => void;
}) {
const { form, handleSubmit } = props;
const isNameDirty = form.getFieldState("name").isDirty;

return (
<SettingsCard
Expand All @@ -419,8 +418,8 @@ function ProjectNameSetting(props: {
errorText={form.getFieldState("name").error?.message}
saveButton={{
onClick: handleSubmit,
disabled: !isNameDirty,
isPending: props.isUpdatingProject && isNameDirty,
disabled: false,
isPending: props.isUpdatingProject,
}}
bottomText="Please use 64 characters at maximum"
>
Expand Down Expand Up @@ -501,7 +500,6 @@ function AllowedDomainsSetting(props: {
handleSubmit: () => void;
}) {
const { form, handleSubmit } = props;
const isDomainsDirty = form.getFieldState("domains").isDirty;

const helperText = (
<ul className="flex list-disc flex-col gap-1.5 py-1 pl-3 text-muted-foreground text-sm [&>li]:pl-1">
Expand Down Expand Up @@ -544,8 +542,8 @@ function AllowedDomainsSetting(props: {
errorText={form.getFieldState("domains", form.formState).error?.message}
saveButton={{
onClick: handleSubmit,
disabled: !isDomainsDirty,
isPending: props.isUpdatingProject && isDomainsDirty,
disabled: false,
isPending: props.isUpdatingProject,
}}
bottomText="This is only applicable for web applications"
>
Expand Down Expand Up @@ -606,13 +604,12 @@ function AllowedBundleIDsSetting(props: {
handleSubmit: () => void;
}) {
const { form, handleSubmit } = props;
const isBundleIdsDirty = form.getFieldState("bundleIds").isDirty;
return (
<SettingsCard
saveButton={{
onClick: handleSubmit,
disabled: !isBundleIdsDirty,
isPending: props.isUpdatingProject && isBundleIdsDirty,
disabled: false,
isPending: props.isUpdatingProject,
}}
noPermissionText={undefined}
header={{
Expand Down Expand Up @@ -715,7 +712,7 @@ function EnabledServicesSetting(props: {
errorText={undefined}
saveButton={{
onClick: handleSubmit,
disabled: !form.formState.isDirty,
disabled: false,
isPending: props.isUpdatingProject,
}}
bottomText=""
Expand Down Expand Up @@ -1219,8 +1216,6 @@ function TransferProject(props: {
selectedTeamId === props.currentTeamId ||
!props.isOwnerAccount;

console.log({ selectedTeam: selectedTeamWithRole, isDisabled });

const handleTransfer = () => {
if (!hasOwnerRole) {
return;
Expand Down
Loading