Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 20, 2025


PR-Codex overview

This PR focuses on enhancing the fromProvider function by allowing it to pass the chainId to the internal EIP1193Provider when connecting, improving compatibility with different blockchain networks.

Detailed summary

  • Updated FromEip1193AdapterOptions to accept an optional chainId parameter in the provider function.
  • Modified getProvider to accept params and pass them to the provider function.
  • Adjusted calls to getProvider in connectEip1193Wallet and autoConnectEip1193Wallet to include the chainId.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 9:49pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 9:49pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 9:49pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 9:49pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 9:49pm

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: 9a69a11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review March 20, 2025 21:41
@joaquim-verges joaquim-verges requested review from a team as code owners March 20, 2025 21:41
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 20, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 131 ms (+120.06% 🔺) 1.1 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 213 ms (+27.52% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 80 ms (+1519.13% 🔺) 192 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 16 ms (+961.69% 🔺) 26 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 76 ms (+395.82% 🔺) 462 ms

@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.96%. Comparing base (d14a78c) to head (9a69a11).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ages/thirdweb/src/adapters/eip1193/from-eip1193.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6506      +/-   ##
==========================================
+ Coverage   54.77%   54.96%   +0.18%     
==========================================
  Files         875      881       +6     
  Lines       54903    55148     +245     
  Branches     3739     3767      +28     
==========================================
+ Hits        30073    30311     +238     
- Misses      24735    24742       +7     
  Partials       95       95              
Flag Coverage Δ
packages 54.96% <85.71%> (+0.18%) ⬆️
Files with missing lines Coverage Δ
...ages/thirdweb/src/adapters/eip1193/from-eip1193.ts 70.47% <85.71%> (-0.56%) ⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit d854021 into main Mar 20, 2025
35 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_Pass_chainId_to_internal_1193_provider_when_connecting branch March 20, 2025 21:52
@joaquim-verges joaquim-verges mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants