-
Notifications
You must be signed in to change notification settings - Fork 621
[SDK] fix: Pass chainId to internal 1193 provider when connecting #6506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] fix: Pass chainId to internal 1193 provider when connecting #6506
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 9a69a11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6506 +/- ##
==========================================
+ Coverage 54.77% 54.96% +0.18%
==========================================
Files 875 881 +6
Lines 54903 55148 +245
Branches 3739 3767 +28
==========================================
+ Hits 30073 30311 +238
- Misses 24735 24742 +7
Partials 95 95
🚀 New features to boost your workflow:
|

PR-Codex overview
This PR focuses on enhancing the
fromProviderfunction by allowing it to pass thechainIdto the internalEIP1193Providerwhen connecting, improving compatibility with different blockchain networks.Detailed summary
FromEip1193AdapterOptionsto accept an optionalchainIdparameter in theproviderfunction.getProviderto acceptparamsand pass them to theproviderfunction.getProviderinconnectEip1193WalletandautoConnectEip1193Walletto include thechainId.