-
Notifications
You must be signed in to change notification settings - Fork 621
[SDK] fix: Improve swap transaction details UI #6509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] fix: Improve swap transaction details UI #6509
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2609b1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/swap/ConfirmationScreen.tsx
Outdated
Show resolved
Hide resolved
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (1.02%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6509 +/- ##
==========================================
- Coverage 54.95% 54.94% -0.01%
==========================================
Files 881 881
Lines 55148 55163 +15
Branches 3765 3766 +1
==========================================
+ Hits 30306 30309 +3
- Misses 24747 24759 +12
Partials 95 95
🚀 New features to boost your workflow:
|
7982716 to
2609b1c
Compare

PR-Codex overview
This PR focuses on improving the user interface for swap status in the
PayEmbed, enhancing the display and interactivity of transaction details within the wallet connection screens.Detailed summary
gapinTokenInfoRow.tsxfromxxsto3xs.TokenInfoRow.tsxfor better readability.showDetailsstate inSwapStatusScreen.tsxto toggle transaction details.SwapStatusScreen.tsx.SwapStatusScreen.tsx.SwapTxDetailsTableto display "Received" instead of "Receive."SwapTxDetailsTable.ConfirmationScreen.tsxto streamline transaction handling and improve button interactions.