-
Notifications
You must be signed in to change notification settings - Fork 621
[SDK] Fix: Pause after onramp step #6513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 4756780 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6513 +/- ##
==========================================
- Coverage 54.94% 54.94% -0.01%
==========================================
Files 881 881
Lines 55163 55164 +1
Branches 3766 3767 +1
==========================================
Hits 30309 30309
- Misses 24759 24760 +1
Partials 95 95
🚀 New features to boost your workflow:
|
| } else if (swapQuoteQuery.data && !swapTxHash) { | ||
| // Execute swap/bridge | ||
| try { | ||
| await new Promise((resolve) => setTimeout(resolve, 1000)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think that's the issue
PR-Codex overview
This PR focuses on fixing a race condition in the
onrampwidget of thethirdwebpackage by introducing a delay before executing a swap/bridge operation.Detailed summary
thirdwebpackage version to a patch.setTimeoutbefore executing the swap/bridge in theOnRampScreen.tsxfile.