Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Mar 22, 2025


PR-Codex overview

This PR focuses on fixing a race condition in the onramp widget of the thirdweb package by introducing a delay before executing a swap/bridge operation.

Detailed summary

  • Updated the thirdweb package version to a patch.
  • Added a delay of 1000 milliseconds using setTimeout before executing the swap/bridge in the OnRampScreen.tsx file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2025

🦋 Changeset detected

Latest commit: 4756780

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 0:32am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 0:32am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 0:32am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 0:32am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 0:32am

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 22, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 189 ms (+185.84% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 269 ms (+69.16% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 109 ms (+1726.1% 🔺) 221 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 56 ms (+3563% 🔺) 66 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (+0.04% 🔺) 387 ms (+0.04% 🔺) 136 ms (+1115.34% 🔺) 523 ms

@codecov
Copy link

codecov bot commented Mar 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.94%. Comparing base (7476b79) to head (4756780).

Files with missing lines Patch % Lines
...ui/ConnectWallet/screens/Buy/fiat/OnRampScreen.tsx 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6513      +/-   ##
==========================================
- Coverage   54.94%   54.94%   -0.01%     
==========================================
  Files         881      881              
  Lines       55163    55164       +1     
  Branches     3766     3767       +1     
==========================================
  Hits        30309    30309              
- Misses      24759    24760       +1     
  Partials       95       95              
Flag Coverage Δ
packages 54.94% <0.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...ui/ConnectWallet/screens/Buy/fiat/OnRampScreen.tsx 5.79% <0.00%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

} else if (swapQuoteQuery.data && !swapTxHash) {
// Execute swap/bridge
try {
await new Promise((resolve) => setTimeout(resolve, 1000));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think that's the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants