Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 22, 2025


PR-Codex overview

This PR focuses on enhancing the PayEmbed component by ensuring it always fetches fresh quotes before executing transactions and updates the handling of token information during the swap process.

Detailed summary

  • Updated StyledPayEmbedPreview to include connectOptions with accountAbstraction.
  • Removed old swapQuoteQuery logic and replaced it with fresh quote fetching in useSwapMutation.
  • Modified the mutation function to accept fromToken, toToken, and amount directly.
  • Adjusted error handling to only check for swapMutation errors.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 7:13am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 7:13am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 7:13am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 7:13am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 7:13am

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2025

🦋 Changeset detected

Latest commit: 286cd63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Mar 22, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 235 ms (+161.87% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 327 ms (+29.97% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 106 ms (+1618.25% 🔺) 218 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 52 ms (+1268.19% 🔺) 62 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 172 ms (+926.01% 🔺) 559 ms

@codecov
Copy link

codecov bot commented Mar 22, 2025

Codecov Report

Attention: Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review.

Project coverage is 54.94%. Comparing base (e540dc1) to head (286cd63).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ui/ConnectWallet/screens/Buy/fiat/OnRampScreen.tsx 4.54% 21 Missing ⚠️

❌ Your patch status has failed because the patch coverage (4.54%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6515   +/-   ##
=======================================
  Coverage   54.94%   54.94%           
=======================================
  Files         881      881           
  Lines       55163    55159    -4     
  Branches     3768     3766    -2     
=======================================
  Hits        30309    30309           
+ Misses      24759    24755    -4     
  Partials       95       95           
Flag Coverage Δ
packages 54.94% <4.54%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
...ui/ConnectWallet/screens/Buy/fiat/OnRampScreen.tsx 5.84% <4.54%> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit c407bd1 into main Mar 22, 2025
34 of 35 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_Fetch_fresh_quotes_before_post_onramp_step_in_PayEmbed branch March 22, 2025 07:14
@joaquim-verges joaquim-verges mentioned this pull request Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants