Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 22, 2025


PR-Codex overview

This PR focuses on handling wallet chain mismatches during the onramp flow and improving the account handling in various components within the thirdweb library.

Detailed summary

  • Updated wallet chain handling in apps/playground-web/src/components/pay/embed.tsx.
  • Improved error handling for transactions in packages/thirdweb/src/wallets/smart/index.ts.
  • Enhanced wallet chain verification and switching in packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/swap/ConfirmationScreen.tsx.
  • Added wallet chain checks in packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/fiat/OnRampScreen.tsx.
  • Refactored account access from props.payer to direct wallet account access across multiple files.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 11:54am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 11:54am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 11:54am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 11:54am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 11:54am

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2025

🦋 Changeset detected

Latest commit: 4a4d749

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review March 22, 2025 10:42
@joaquim-verges joaquim-verges requested review from a team as code owners March 22, 2025 10:42
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 22, 2025
Copy link
Member Author

joaquim-verges commented Mar 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 192 ms (+142.32% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 322 ms (+19.79% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 107 ms (+1588.1% 🔺) 219 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 45 ms (+1012.63% 🔺) 55 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 111 ms (+637.64% 🔺) 498 ms

@codecov
Copy link

codecov bot commented Mar 22, 2025

Codecov Report

Attention: Patch coverage is 13.46154% with 45 lines in your changes missing coverage. Please review.

Project coverage is 54.93%. Comparing base (d3f7884) to head (4a4d749).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nectWallet/screens/Buy/swap/ConfirmationScreen.tsx 0.00% 20 Missing ⚠️
...ui/ConnectWallet/screens/Buy/fiat/OnRampScreen.tsx 0.00% 19 Missing ⚠️
packages/thirdweb/src/wallets/smart/index.ts 53.84% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6518      +/-   ##
==========================================
- Coverage   54.94%   54.93%   -0.02%     
==========================================
  Files         881      881              
  Lines       55159    55184      +25     
  Branches     3763     3766       +3     
==========================================
+ Hits        30305    30313       +8     
- Misses      24759    24776      +17     
  Partials       95       95              
Flag Coverage Δ
packages 54.93% <13.46%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/smart/index.ts 60.72% <53.84%> (-0.32%) ⬇️
...ui/ConnectWallet/screens/Buy/fiat/OnRampScreen.tsx 5.77% <0.00%> (-0.08%) ⬇️
...nectWallet/screens/Buy/swap/ConfirmationScreen.tsx 8.91% <0.00%> (-0.29%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges force-pushed the _SDK_fix_Handle_wallet_chain_mismatch_on_post_onramp_flow branch from 07aad25 to 4a4d749 Compare March 22, 2025 11:46
@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Mar 22, 2025
@joaquim-verges joaquim-verges merged commit 744491f into main Mar 22, 2025
30 of 33 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_Handle_wallet_chain_mismatch_on_post_onramp_flow branch March 22, 2025 11:53
@joaquim-verges joaquim-verges mentioned this pull request Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants