Skip to content

Conversation

@pinkhoodie
Copy link
Contributor

@pinkhoodie pinkhoodie commented Mar 23, 2025


PR-Codex overview

This PR updates the Get Started documentation for wallet integration, focusing on the terminology and functionality of wallets, enhancing clarity and detail for users.

Detailed summary

  • Changed the title from "Get started with Connect" to "Get started with wallets".
  • Updated the description to reflect wallet integration.
  • Revised introductory text to specify 4 types of wallets.
  • Enhanced details about wallet types, including links for Ecosystem Wallets and Smart Wallets.
  • Modified the Setup Ecosystem Wallet section to emphasize unified identity.
  • Removed the Performance Considerations section entirely.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@pinkhoodie pinkhoodie requested review from a team as code owners March 23, 2025 17:00
@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2025

⚠️ No Changeset found

Latest commit: 8cea85c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@vercel
Copy link

vercel bot commented Mar 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 23, 2025 5:06pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Mar 23, 2025 5:06pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 23, 2025 5:06pm
thirdweb-www ⬜️ Skipped (Inspect) Mar 23, 2025 5:06pm
wallet-ui ⬜️ Skipped (Inspect) Mar 23, 2025 5:06pm

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Mar 23, 2025
@codecov
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.93%. Comparing base (0b8907c) to head (8cea85c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6525   +/-   ##
=======================================
  Coverage   54.93%   54.93%           
=======================================
  Files         881      881           
  Lines       55184    55184           
  Branches     3768     3768           
=======================================
  Hits        30313    30313           
  Misses      24776    24776           
  Partials       95       95           
Flag Coverage Δ
packages 54.93% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 380 ms (+46.49% 🔺) 1.4 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 714 ms (+16.65% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 54 ms (+142.02% 🔺) 166 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 42 ms (+642.59% 🔺) 52 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 123 ms (+167.23% 🔺) 510 ms

@joaquim-verges joaquim-verges merged commit a0cee48 into main Mar 23, 2025
33 checks passed
@joaquim-verges joaquim-verges deleted the nk/get-started-fix branch March 23, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants