Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 23, 2025


PR-Codex overview

This PR focuses on adding a new service called engineCloud to the @thirdweb-dev/service-utils package, enhancing the functionality of server wallets with high transaction throughput and low latency.

Detailed summary

  • Added engineCloud service with the following properties:
    • name: "engineCloud"
    • title: "Server wallets"
    • description: "Server wallets with high transaction throughput and low latency"
    • actions: [] (all actions allowed)

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 7:02am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 7:02am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 7:02am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 7:02am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 7:02am

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2025

🦋 Changeset detected

Latest commit: 18a55ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login March 23, 2025 22:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 23, 2025 22:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 23, 2025 22:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 23, 2025 22:54 Inactive
@joaquim-verges joaquim-verges marked this pull request as ready for review March 23, 2025 22:54
@joaquim-verges joaquim-verges requested a review from a team as a code owner March 23, 2025 22:54
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.93%. Comparing base (d3f7884) to head (18a55ce).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6526      +/-   ##
==========================================
- Coverage   54.94%   54.93%   -0.02%     
==========================================
  Files         881      881              
  Lines       55159    55184      +25     
  Branches     3763     3768       +5     
==========================================
+ Hits        30305    30313       +8     
- Misses      24759    24776      +17     
  Partials       95       95              
Flag Coverage Δ
packages 54.93% <ø> (-0.02%) ⬇️

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 164 ms (+189.51% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 224 ms (+41.37% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 125 ms (+2659.56% 🔺) 237 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 33 ms (+1052.16% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 90 ms (+494.18% 🔺) 476 ms

@joaquim-verges joaquim-verges force-pushed the _Service-Utils_feat_Add_engine-cloud_service_definition branch from 8729e21 to 5a82c32 Compare March 23, 2025 23:05
@vercel vercel bot temporarily deployed to Preview – login March 23, 2025 23:05 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 23, 2025 23:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 23, 2025 23:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 23, 2025 23:05 Inactive
@joaquim-verges joaquim-verges force-pushed the _Service-Utils_feat_Add_engine-cloud_service_definition branch from 5a82c32 to f6a94af Compare March 24, 2025 06:49
@vercel vercel bot temporarily deployed to Preview – login March 24, 2025 06:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 24, 2025 06:49 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 24, 2025 06:49 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 24, 2025 06:50 Inactive
@joaquim-verges joaquim-verges merged commit 21389bb into main Mar 24, 2025
33 checks passed
@joaquim-verges joaquim-verges deleted the _Service-Utils_feat_Add_engine-cloud_service_definition branch March 24, 2025 07:16
@joaquim-verges joaquim-verges mentioned this pull request Mar 24, 2025
joaquim-verges added a commit that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants