Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 25, 2025


PR-Codex overview

This PR focuses on updating dependencies and modifying test suite descriptions to conditionally run based on the environment variable TW_SECRET_KEY.

Detailed summary

  • Updated dependencies in package.json files for @thirdweb-dev/wagmi-adapter and thirdweb.
  • Changed describe blocks in test files (Routes.test.ts, Buy.test.ts, Sell.test.ts, Status.test.ts) to use describe.runIf(process.env.TW_SECRET_KEY).
  • Updated vitest version from 3.0.8 to 3.0.9 across multiple locations.
  • Adjusted @walletconnect packages from 2.17.5 to 2.19.1 in various dependencies.
  • Refined typesVersions entries in package.json files for better clarity and organization.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 9:30am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 9:30am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 9:30am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 9:30am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 9:30am

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2025

🦋 Changeset detected

Latest commit: fc04d33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@thirdweb-dev/wagmi-adapter Patch
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 25, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 170 ms (+198.67% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 223 ms (+32.71% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 107 ms (+2399.23% 🔺) 219 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 31 ms (+1317.93% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 107 ms (+676.7% 🔺) 494 ms

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (dd65506) to head (fc04d33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6545      +/-   ##
==========================================
- Coverage   55.02%   55.02%   -0.01%     
==========================================
  Files         881      881              
  Lines       55304    55304              
  Branches     3788     3787       -1     
==========================================
- Hits        30433    30429       -4     
- Misses      24776    24780       +4     
  Partials       95       95              
Flag Coverage Δ
packages 55.02% <ø> (-0.01%) ⬇️

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges force-pushed the _Bridge_Skip_tests_without_TW_SECRET_KEY_environment_variable branch from 3737a39 to 25c6dfb Compare March 25, 2025 08:46
@socket-security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@codspeed/[email protected]4.0.1 Transitive: environment, eval, filesystem, network +31 4.73 MB art049
npm/@vitest/[email protected]3.0.9 Transitive: environment, filesystem, shell +57 10.5 MB antfu, oreanno, patak, ...1 more
npm/@vitest/[email protected] Transitive: environment, filesystem +14 1.28 MB
npm/@wagmi/[email protected] Transitive: environment, network +8 8.56 MB awkweb
npm/[email protected] Transitive: environment, filesystem, shell, unsafe +33 2.01 MB

🚮 Removed packages: npm/@walletconnect/[email protected], npm/@walletconnect/[email protected]

View full report↗︎

@joaquim-verges joaquim-verges deleted the _Bridge_Skip_tests_without_TW_SECRET_KEY_environment_variable branch March 25, 2025 09:32
@joaquim-verges joaquim-verges mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants