Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Mar 25, 2025


PR-Codex overview

This PR focuses on updating the structure of the sidebar object in sidebar.tsx to improve readability and maintainability by correcting the formatting of the array and object closures.

Detailed summary

  • Corrected the closing brackets for the sidebar structure.
  • Ensured proper formatting by aligning array and object closures.
  • Clarified the structure of the MCP Server and Tools sections in the sidebar configuration.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – login March 25, 2025 17:58 Inactive
@vercel
Copy link

vercel bot commented Mar 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 7:38pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Mar 25, 2025 7:38pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 25, 2025 7:38pm
thirdweb-www ⬜️ Skipped (Inspect) Mar 25, 2025 7:38pm
wallet-ui ⬜️ Skipped (Inspect) Mar 25, 2025 7:38pm

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: 1a9448e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui March 25, 2025 17:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 25, 2025 17:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 25, 2025 17:58 Inactive
@MananTank MananTank marked this pull request as ready for review March 25, 2025 17:58
@MananTank MananTank requested review from a team as code owners March 25, 2025 17:58
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Mar 25, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (2fe1611) to head (1a9448e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6552   +/-   ##
=======================================
  Coverage   55.02%   55.02%           
=======================================
  Files         881      881           
  Lines       55304    55304           
  Branches     3787     3787           
=======================================
  Hits        30429    30429           
  Misses      24780    24780           
  Partials       95       95           
Flag Coverage Δ
packages 55.02% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 235 ms (+87.71% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 386 ms (+25.89% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 52 ms (+508.87% 🔺) 164 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 9 ms (+169.1% 🔺) 19 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 89 ms (+209.46% 🔺) 476 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 25, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on restructuring the `sidebar` object in the `apps/portal/src/app/nebula/sidebar.tsx` file, ensuring proper formatting of the sidebar items and improving the overall readability of the code.

### Detailed summary
- Adjusted the formatting of the `sidebar` entries for `MCP Server` and `Tools`.
- Converted closing brackets from separate lines to inline, enhancing code clarity.
- Ensured consistent object structure for items in the `sidebar`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 03-25-portal_fix_lint_error branch from 6f22169 to 1a9448e Compare March 25, 2025 19:36
@vercel vercel bot temporarily deployed to Preview – login March 25, 2025 19:36 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 25, 2025 19:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 25, 2025 19:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 25, 2025 19:36 Inactive
@graphite-app graphite-app bot merged commit 1a9448e into main Mar 25, 2025
26 of 31 checks passed
@graphite-app graphite-app bot deleted the 03-25-portal_fix_lint_error branch March 25, 2025 19:40
@vercel vercel bot temporarily deployed to Production – login March 25, 2025 19:40 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 25, 2025 19:40 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www March 25, 2025 19:40 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui March 25, 2025 19:40 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants