Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 26, 2025


PR-Codex overview

This PR introduces several new SVG icon components for a product interface and updates the Page component to include new sections for a playground and learning resources, enhancing the overall UI and functionality.

Detailed summary

  • Added new SVG icon components:
    • EngineIcon
    • ContractsIcon
    • PlaygroundIcon
    • ConnectIcon
    • InsightIcon
    • BridgeIcon
    • NebulaIcon
  • Updated SDKCard to accept an optional iconClassName prop.
  • Refactored Page component:
    • Replaced FrontendSection and BackendSection with PlaygroundSection and LearningResourcesSection.
    • Created a new ReferenceSection for API references.
    • Added multiple SDKCard components for different SDKs.
  • Enhanced ArticleCardIndex to support icons and external links.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2025

⚠️ No Changeset found

Latest commit: 98d3d7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 9:41am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Mar 26, 2025 9:41am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 26, 2025 9:41am
thirdweb-www ⬜️ Skipped (Inspect) Mar 26, 2025 9:41am
wallet-ui ⬜️ Skipped (Inspect) Mar 26, 2025 9:41am

@vercel vercel bot temporarily deployed to Preview – login March 26, 2025 09:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 26, 2025 09:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 26, 2025 09:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 26, 2025 09:26 Inactive
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Mar 26, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review March 26, 2025 09:26
@joaquim-verges joaquim-verges requested review from a team as code owners March 26, 2025 09:26
<section>
<SectionTitle id="backend" title="Backend" />
<div className="flex flex-col gap-4">
<SectionTitle id="frontend" title="Learning Resources" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id="frontend" attribute is duplicated across multiple section titles (lines 78 and 154). HTML requires unique IDs for proper document structure, accessibility, and anchor navigation functionality. Consider replacing this instance with a more descriptive and unique ID such as id="learning-resources" to match the section's title and purpose.

Suggested change
<SectionTitle id="frontend" title="Learning Resources" />
<SectionTitle id="learning-resources" title="Learning Resources" />

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.07%. Comparing base (cff2481) to head (98d3d7b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6558   +/-   ##
=======================================
  Coverage   55.07%   55.07%           
=======================================
  Files         883      883           
  Lines       55362    55362           
  Branches     3789     3789           
=======================================
  Hits        30491    30491           
  Misses      24776    24776           
  Partials       95       95           
Flag Coverage Δ
packages 55.07% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 1.7 s (+8.12% 🔺) 2.7 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 5.2 s (-1.03% 🔽) 7.7 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 186 ms (+32.56% 🔺) 298 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 43 ms (-75.47% 🔽) 53 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 515 ms (+40.38% 🔺) 902 ms

@joaquim-verges joaquim-verges force-pushed the _Portal_Redesign_documentation_homepage_with_SDK_cards_and_product_icons branch from 8f5d513 to 98d3d7b Compare March 26, 2025 09:33
@vercel vercel bot temporarily deployed to Preview – login March 26, 2025 09:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 26, 2025 09:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 26, 2025 09:33 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 26, 2025 09:33 Inactive
@joaquim-verges joaquim-verges merged commit fc657e0 into main Mar 26, 2025
31 of 32 checks passed
@joaquim-verges joaquim-verges deleted the _Portal_Redesign_documentation_homepage_with_SDK_cards_and_product_icons branch March 26, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants