Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Mar 28, 2025

PR-Codex overview

This PR focuses on updating the className property in two components, pagination.tsx and breadcrumb.tsx, to include a relative positioning style.

Detailed summary

  • In pagination.tsx, the className property is modified to include relative:

    • Changed from className={cn("flex h-9 w-9 items-center justify-center", className)}
    • To className={cn("relative flex h-9 w-9 items-center justify-center", className)}
  • In breadcrumb.tsx, the same change is applied to the className property:

    • Changed from className={cn("flex h-9 w-9 items-center justify-center", className)}
    • To className={cn("relative flex h-9 w-9 items-center justify-center", className)}

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – docs-v2 March 28, 2025 19:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 28, 2025 19:07 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 28, 2025 19:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 28, 2025 19:07 Inactive
@vercel
Copy link

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 7:24pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 28, 2025 7:24pm
login ⬜️ Skipped (Inspect) Mar 28, 2025 7:24pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 28, 2025 7:24pm
wallet-ui ⬜️ Skipped (Inspect) Mar 28, 2025 7:24pm

@linear
Copy link

linear bot commented Mar 28, 2025

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2025

⚠️ No Changeset found

Latest commit: a4ff738

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 28, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review March 28, 2025 19:07
@MananTank MananTank requested review from a team as code owners March 28, 2025 19:07
@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Mar 28, 2025 — with Graphite App
@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.99%. Comparing base (b49c191) to head (a4ff738).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6576   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files         885      885           
  Lines       55492    55492           
  Branches     3795     3795           
=======================================
  Hits        30517    30517           
  Misses      24880    24880           
  Partials       95       95           
Flag Coverage Δ
packages 54.99% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 285 ms (+52.08% 🔺) 1.3 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 581 ms (+4.89% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 105 ms (+315.09% 🔺) 217 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 80 ms (+1073.36% 🔺) 90 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 153 ms (+136.76% 🔺) 540 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 28, 2025

Merge activity

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 28, 2025 19:17 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 28, 2025 19:17 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 28, 2025 19:17 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 28, 2025 19:17 Inactive
@graphite-app graphite-app bot merged commit a4ff738 into main Mar 28, 2025
32 checks passed
@graphite-app graphite-app bot removed the hotfix This pull request should be prioritized in the merge queue. label Mar 28, 2025
@graphite-app graphite-app bot deleted the tool-3833 branch March 28, 2025 19:24
@vercel vercel bot temporarily deployed to Production – wallet-ui March 28, 2025 19:24 Inactive
@vercel vercel bot temporarily deployed to Production – login March 28, 2025 19:24 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 March 28, 2025 19:24 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 28, 2025 19:24 Inactive
@MananTank MananTank changed the title [TOOL-3833] Dashboard: Fix overflow scroll created by sr-only element [TOOL-3833] Dashboard: Fix overflow scroll created by sr-only element in project pages Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants