Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 31, 2025

Fixes TOOL-3864


PR-Codex overview

This PR introduces an erc20Value property in the makeOffer function of the thirdweb marketplace extension, allowing for better handling of offers that involve ERC20 tokens.

Detailed summary

  • Added erc20Value in the overrides object of the makeOffer function.
  • The erc20Value is conditionally set based on whether the currency is a native token address.
  • If not a native token, it includes tokenAddress and amountWei for the ERC20 token.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 7:24am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 7:24am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 7:24am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 7:24am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 7:24am

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2025

🦋 Changeset detected

Latest commit: 4e96dc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 31, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title [Marketplace] Add erc20Value for makeOffer extension function [SDK] Add erc20Value for makeOffer extension function Mar 31, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review March 31, 2025 07:16
@joaquim-verges joaquim-verges requested review from a team as code owners March 31, 2025 07:16
@linear
Copy link

linear bot commented Mar 31, 2025

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 175 ms (+187.47% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 233 ms (+48.97% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 108 ms (+2140.03% 🔺) 220 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 66 ms (+2080.71% 🔺) 76 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 138 ms (+830.32% 🔺) 525 ms

@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 54.96%. Comparing base (dc892bd) to head (4e96dc9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/extensions/marketplace/offers/write/makeOffer.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6588      +/-   ##
==========================================
- Coverage   54.99%   54.96%   -0.04%     
==========================================
  Files         885      885              
  Lines       55509    55517       +8     
  Branches     3795     3793       -2     
==========================================
- Hits        30528    30513      -15     
- Misses      24886    24911      +25     
+ Partials       95       93       -2     
Flag Coverage Δ
packages 54.96% <0.00%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
...c/extensions/marketplace/offers/write/makeOffer.ts 4.76% <0.00%> (-0.70%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit cd9ea69 into main Mar 31, 2025
34 of 35 checks passed
@joaquim-verges joaquim-verges deleted the _Marketplace_Add_erc20Value_for_makeOffer_extension_function branch March 31, 2025 07:24
@joaquim-verges joaquim-verges mentioned this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants