-
Notifications
You must be signed in to change notification settings - Fork 621
[SDK] Add erc20Value for makeOffer extension function #6588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Add erc20Value for makeOffer extension function #6588
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 4e96dc9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6588 +/- ##
==========================================
- Coverage 54.99% 54.96% -0.04%
==========================================
Files 885 885
Lines 55509 55517 +8
Branches 3795 3793 -2
==========================================
- Hits 30528 30513 -15
- Misses 24886 24911 +25
+ Partials 95 93 -2
🚀 New features to boost your workflow:
|

Fixes TOOL-3864
PR-Codex overview
This PR introduces an
erc20Valueproperty in themakeOfferfunction of thethirdwebmarketplace extension, allowing for better handling of offers that involve ERC20 tokens.Detailed summary
erc20Valuein theoverridesobject of themakeOfferfunction.erc20Valueis conditionally set based on whether thecurrencyis a native token address.tokenAddressandamountWeifor the ERC20 token.