Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Mar 31, 2025


PR-Codex overview

This PR focuses on refactoring the SmartWalletsBillingAlert component in the Alerts.tsx file. It simplifies the alert's implementation and updates the UI components used for displaying the alert.

Detailed summary

  • Removed dismissible prop and local storage logic.
  • Updated imports for alert components from @/components/ui.
  • Changed alert icon from AlertIcon to CircleAlertIcon.
  • Replaced TrackedLink with TrackedUnderlineLink.
  • Simplified alert structure and styling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 7:14pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 31, 2025 7:14pm
login ⬜️ Skipped (Inspect) Mar 31, 2025 7:14pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 31, 2025 7:14pm
wallet-ui ⬜️ Skipped (Inspect) Mar 31, 2025 7:14pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 31, 2025 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 31, 2025 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 31, 2025 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 31, 2025 18:57 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2025

⚠️ No Changeset found

Latest commit: 1d23e5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 31, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review March 31, 2025 18:57
@MananTank MananTank requested review from a team as code owners March 31, 2025 18:57
@MananTank MananTank changed the title Fix AA page alert styles Dashboard: Fix AA page alert styles Mar 31, 2025
@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (a17d893) to head (1d23e5c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6596   +/-   ##
=======================================
  Coverage   54.98%   54.98%           
=======================================
  Files         885      885           
  Lines       55517    55517           
  Branches     3794     3794           
=======================================
  Hits        30528    30528           
  Misses      24894    24894           
  Partials       95       95           
Flag Coverage Δ
packages 54.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 303 ms (+189.88% 🔺) 1.3 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 438 ms (+42.02% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 98 ms (+935.17% 🔺) 210 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 45 ms (+1584.93% 🔺) 55 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 105 ms (+315.72% 🔺) 492 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 31, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the `SmartWalletsBillingAlert` component in the `Alerts.tsx` file. It updates the alert's UI and removes the dismissible functionality, while also changing the import paths for components used in the alert.

### Detailed summary
- Removed unused imports related to `Alert`, `AlertDescription`, `AlertIcon`, `AlertTitle`, `Flex`, and `IconButton`.
- Updated imports for `Alert`, `AlertDescription`, `AlertTitle`, `TrackedUnderlineLink`, and `CircleAlertIcon`.
- Removed the `dismissible` prop and related logic.
- Simplified the alert structure with a new layout.
- Changed the alert icon and styling.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-01-fix_aa_page_alert_styles branch from 3e81d88 to 1d23e5c Compare March 31, 2025 19:08
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 31, 2025 19:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 31, 2025 19:08 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 31, 2025 19:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 31, 2025 19:08 Inactive
@graphite-app graphite-app bot merged commit 1d23e5c into main Mar 31, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 04-01-fix_aa_page_alert_styles branch March 31, 2025 19:17
@vercel vercel bot temporarily deployed to Production – docs-v2 March 31, 2025 19:17 Inactive
@vercel vercel bot temporarily deployed to Production – login March 31, 2025 19:17 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 31, 2025 19:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants