-
Notifications
You must be signed in to change notification settings - Fork 621
[SDK] Only onramp for required transaction amount #6605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Only onramp for required transaction amount #6605
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: bc61dbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
c91cc5a to
bc61dbf
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6605 +/- ##
==========================================
- Coverage 54.98% 54.97% -0.02%
==========================================
Files 885 885
Lines 55517 55517
Branches 3794 3791 -3
==========================================
- Hits 30528 30519 -9
- Misses 24894 24903 +9
Partials 95 95
🚀 New features to boost your workflow:
|

PR-Codex overview
This PR focuses on modifying the
thirdwebpackage, particularly enhancing transaction flow handling inPayEmbed, adjusting test descriptions to conditionally run based on an environment variable, and refining the formatting of amounts and transaction cost calculations.Detailed summary
getTransfer.tsto removegasfrom the transaction request.Buy.test.tsandSell.test.tsto usedescribe.runIf(process.env.TW_SECRET_KEY).BuyScreen.tsxfrom 5 to 6.totalCostWeiinTransactionModeScreen.tsxto account for insufficient funds.