Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 1, 2025


PR-Codex overview

This PR focuses on modifying the thirdweb package, particularly enhancing transaction flow handling in PayEmbed, adjusting test descriptions to conditionally run based on an environment variable, and refining the formatting of amounts and transaction cost calculations.

Detailed summary

  • Updated getTransfer.ts to remove gas from the transaction request.
  • Changed test descriptions in Buy.test.ts and Sell.test.ts to use describe.runIf(process.env.TW_SECRET_KEY).
  • Adjusted the number of decimal places in BuyScreen.tsx from 5 to 6.
  • Modified the calculation of totalCostWei in TransactionModeScreen.tsx to account for insufficient funds.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 8:53am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 8:53am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 8:53am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 8:53am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 8:53am

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025

🦋 Changeset detected

Latest commit: bc61dbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 1, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title [PayEmbed] Only onramp for required transaction amount [SDK] Only onramp for required transaction amount Apr 1, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review April 1, 2025 08:38
@joaquim-verges joaquim-verges requested review from a team as code owners April 1, 2025 08:38
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.54 KB (-0.03% 🔽) 951 ms (-0.03% 🔽) 173 ms (+172.31% 🔺) 1.2 s
thirdweb (cjs) 127.41 KB (+0.08% 🔺) 2.6 s (+0.08% 🔺) 258 ms (+62.23% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 111 ms (+2292.32% 🔺) 223 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 86 ms (+3769.7% 🔺) 96 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 134 ms (+734.28% 🔺) 521 ms

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 54.97%. Comparing base (cbb1569) to head (bc61dbf).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...onnectWallet/screens/Buy/TransactionModeScreen.tsx 0.00% 4 Missing ⚠️
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6605      +/-   ##
==========================================
- Coverage   54.98%   54.97%   -0.02%     
==========================================
  Files         885      885              
  Lines       55517    55517              
  Branches     3794     3791       -3     
==========================================
- Hits        30528    30519       -9     
- Misses      24894    24903       +9     
  Partials       95       95              
Flag Coverage Δ
packages 54.97% <0.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
...ackages/thirdweb/src/pay/buyWithCrypto/getQuote.ts 5.55% <ø> (+0.15%) ⬆️
...ages/thirdweb/src/pay/buyWithCrypto/getTransfer.ts 7.40% <ø> (+0.13%) ⬆️
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 4.57% <0.00%> (ø)
...onnectWallet/screens/Buy/TransactionModeScreen.tsx 9.00% <0.00%> (-0.09%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 38e089a into main Apr 1, 2025
32 of 33 checks passed
@joaquim-verges joaquim-verges deleted the _PayEmbed_Only_onramp_for_required_transaction_amount branch April 1, 2025 09:01
@joaquim-verges joaquim-verges mentioned this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants