Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 1, 2025

PR-Codex overview

This PR focuses on enhancing the Nebula components in the dashboard by improving layout styles, adding project ID handling in analytics fetching, and adjusting the logic for displaying the Nebula waitlist and sidebar.

Detailed summary

  • Updated className for styling in nebula-analytics-filter.tsx.
  • Removed container class in nebula-waitlist-page.tsx for layout simplification.
  • Added projectId to parameters in fetch-nebula-analytics.tsx.
  • Modified header and container styles in nebula-waitlist-page-ui.client.tsx.
  • Removed getTeamNebulaWaitList call in layout.tsx.
  • Passed showNebula prop to ProjectSidebarLayout in layout.tsx.
  • Updated NebulaAnalyticsPage to include projectId.
  • Adjusted redirects in the main page logic to handle project validation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Apr 1, 2025

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025

⚠️ No Changeset found

Latest commit: 447a519

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 0:03am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 1, 2025 0:03am
login ⬜️ Skipped (Inspect) Apr 1, 2025 0:03am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 1, 2025 0:03am
wallet-ui ⬜️ Skipped (Inspect) Apr 1, 2025 0:03am

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 1, 2025 11:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 1, 2025 11:35 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 1, 2025 11:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 1, 2025 11:35 Inactive
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 1, 2025
@MananTank MananTank marked this pull request as ready for review April 1, 2025 11:37
@MananTank MananTank requested review from a team as code owners April 1, 2025 11:37
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a redirect from team nebula page to team root page but rest LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.61 KB (0%) 953 ms (0%) 192 ms (+227.05% 🔺) 1.2 s
thirdweb (cjs) 127.63 KB (0%) 2.6 s (0%) 246 ms (+55.74% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 115 ms (+1565.8% 🔺) 227 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 39 ms (+2297.08% 🔺) 49 ms
thirdweb/react (minimal + tree-shaking) 19.35 KB (0%) 388 ms (0%) 122 ms (+867.52% 🔺) 509 ms

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.91%. Comparing base (38e089a) to head (447a519).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6608      +/-   ##
==========================================
- Coverage   54.97%   54.91%   -0.06%     
==========================================
  Files         885      885              
  Lines       55517    55581      +64     
  Branches     3791     3791              
==========================================
+ Hits        30519    30522       +3     
- Misses      24903    24964      +61     
  Partials       95       95              
Flag Coverage Δ
packages 54.91% <ø> (-0.06%) ⬇️

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 1, 2025

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on enhancing the `Nebula` components in the dashboard application by improving layout styles, adding project ID handling in analytics, and adjusting waitlist checks.

### Detailed summary
- Updated class names for better styling in `nebula-analytics-filter.tsx` and `nebula-waitlist-page.tsx`.
- Added `projectId` parameter to `fetchNebulaAnalytics`.
- Modified `NebulaWaitListPageUI` layout.
- Integrated `showNebula` prop in `ProjectSidebarLayout`.
- Adjusted project layout and waitlist checks in `layout.tsx`.
- Enhanced `NebulaAnalyticsPage` to pass `projectId`.
- Updated page handling in `page.tsx` to include project fetching and redirects.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 1, 2025 11:56 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 1, 2025 11:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 1, 2025 11:56 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 1, 2025 11:56 Inactive
@graphite-app graphite-app bot merged commit 447a519 into main Apr 1, 2025
32 checks passed
@graphite-app graphite-app bot deleted the tool-3768 branch April 1, 2025 12:03
@vercel vercel bot temporarily deployed to Production – docs-v2 April 1, 2025 12:03 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 1, 2025 12:03 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 1, 2025 12:03 Inactive
@vercel vercel bot temporarily deployed to Production – login April 1, 2025 12:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants