-
Notifications
You must be signed in to change notification settings - Fork 621
[TOOL-3768] Dashboard: Move Nebula from team to project layout #6608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
jnsdls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a redirect from team nebula page to team root page but rest LGTM
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6608 +/- ##
==========================================
- Coverage 54.97% 54.91% -0.06%
==========================================
Files 885 885
Lines 55517 55581 +64
Branches 3791 3791
==========================================
+ Hits 30519 30522 +3
- Misses 24903 24964 +61
Partials 95 95
🚀 New features to boost your workflow:
|
Merge activity
|
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on enhancing the `Nebula` components in the dashboard application by improving layout styles, adding project ID handling in analytics, and adjusting waitlist checks.
### Detailed summary
- Updated class names for better styling in `nebula-analytics-filter.tsx` and `nebula-waitlist-page.tsx`.
- Added `projectId` parameter to `fetchNebulaAnalytics`.
- Modified `NebulaWaitListPageUI` layout.
- Integrated `showNebula` prop in `ProjectSidebarLayout`.
- Adjusted project layout and waitlist checks in `layout.tsx`.
- Enhanced `NebulaAnalyticsPage` to pass `projectId`.
- Updated page handling in `page.tsx` to include project fetching and redirects.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
a32d38b to
447a519
Compare

PR-Codex overview
This PR focuses on enhancing the
Nebulacomponents in the dashboard by improving layout styles, adding project ID handling in analytics fetching, and adjusting the logic for displaying theNebulawaitlist and sidebar.Detailed summary
classNamefor styling innebula-analytics-filter.tsx.containerclass innebula-waitlist-page.tsxfor layout simplification.projectIdto parameters infetch-nebula-analytics.tsx.nebula-waitlist-page-ui.client.tsx.getTeamNebulaWaitListcall inlayout.tsx.showNebulaprop toProjectSidebarLayoutinlayout.tsx.NebulaAnalyticsPageto includeprojectId.