Skip to content

Conversation

@kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Apr 1, 2025

Create2 deployer restrictions are lifted by the chain. Enable deployments through default create2 factory.


PR-Codex overview

This PR focuses on removing the custom configuration for the Ronin network from the thirdweb package.

Detailed summary

  • Removed the Ronin network configuration, including its name and gasPrice, from the create-2-factory.ts file.
  • Updated the gasPrice value for another network to 110000n.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kumaryash90 kumaryash90 requested review from a team as code owners April 1, 2025 18:57
@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025

🦋 Changeset detected

Latest commit: 9cf1376

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 7:12pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 7:12pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 7:12pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 7:12pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 7:12pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 1, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 1, 2025
@kumaryash90 kumaryash90 added merge-queue Adds the pull request to Graphite's merge queue. hotfix This pull request should be prioritized in the merge queue. labels Apr 1, 2025
Copy link
Member Author

kumaryash90 commented Apr 1, 2025

Merge activity

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.61 KB (0%) 953 ms (0%) 183 ms (+214.25% 🔺) 1.2 s
thirdweb (cjs) 127.63 KB (0%) 2.6 s (0%) 245 ms (+56.66% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 106 ms (+2377.97% 🔺) 219 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 55 ms (+3469.14% 🔺) 65 ms
thirdweb/react (minimal + tree-shaking) 19.35 KB (0%) 388 ms (0%) 86 ms (+557.08% 🔺) 473 ms

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.92%. Comparing base (58ab8c2) to head (9cf1376).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6612      +/-   ##
==========================================
+ Coverage   54.91%   54.92%   +0.01%     
==========================================
  Files         885      885              
  Lines       55581    55577       -4     
  Branches     3791     3795       +4     
==========================================
+ Hits        30522    30526       +4     
+ Misses      24964    24956       -8     
  Partials       95       95              
Flag Coverage Δ
packages 54.92% <ø> (+0.01%) ⬆️
Files with missing lines Coverage Δ
.../src/contract/deployment/utils/create-2-factory.ts 88.30% <ø> (-0.18%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Create2 deployer restrictions are lifted by the chain. Enable deployments through default create2 factory.

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on removing the custom configuration for the `Ronin` blockchain within the `thirdweb` package.

### Detailed summary
- Removed the `Ronin` configuration from the gas price settings in the `create-2-factory.ts` file.
- Updated the gas price for `Ronin` from `110n * 10n ** 9n` to a static value of `110000n`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the yash/remove-custom-config-ronin branch from 49b9369 to 9cf1376 Compare April 1, 2025 19:06
@graphite-app graphite-app bot merged commit 9cf1376 into main Apr 1, 2025
32 checks passed
@graphite-app graphite-app bot deleted the yash/remove-custom-config-ronin branch April 1, 2025 19:13
@graphite-app graphite-app bot removed merge-queue Adds the pull request to Graphite's merge queue. hotfix This pull request should be prioritized in the merge queue. labels Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants