-
Notifications
You must be signed in to change notification settings - Fork 621
Remove custom config for Ronin #6612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9cf1376 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Merge activity
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6612 +/- ##
==========================================
+ Coverage 54.91% 54.92% +0.01%
==========================================
Files 885 885
Lines 55581 55577 -4
Branches 3791 3795 +4
==========================================
+ Hits 30522 30526 +4
+ Misses 24964 24956 -8
Partials 95 95
🚀 New features to boost your workflow:
|
Create2 deployer restrictions are lifted by the chain. Enable deployments through default create2 factory.
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on removing the custom configuration for the `Ronin` blockchain within the `thirdweb` package.
### Detailed summary
- Removed the `Ronin` configuration from the gas price settings in the `create-2-factory.ts` file.
- Updated the gas price for `Ronin` from `110n * 10n ** 9n` to a static value of `110000n`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
49b9369 to
9cf1376
Compare
Create2 deployer restrictions are lifted by the chain. Enable deployments through default create2 factory.
PR-Codex overview
This PR focuses on removing the custom configuration for the
Roninnetwork from thethirdwebpackage.Detailed summary
Roninnetwork configuration, including itsnameandgasPrice, from thecreate-2-factory.tsfile.gasPricevalue for another network to110000n.