Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Apr 1, 2025


PR-Codex overview

This PR focuses on enhancing the search functionality in the client and server components of the dashboard by improving the search input placeholder and implementing client-side filtering for routes based on various parameters.

Detailed summary

  • Updated the placeholder in the Input component in search.tsx to "Search with anything!".
  • Removed unnecessary server-side filtering parameters in getRoutes function in utils.ts.
  • Added client-side filtering for origin and destination tokens in routes-table.tsx.
  • Introduced originTextQuery and destinationTextQuery to filter routes based on text queries.
  • Enhanced display of filtered route counts with localization in RoutesData component.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners April 1, 2025 22:00
@linear
Copy link

linear bot commented Apr 1, 2025

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025

⚠️ No Changeset found

Latest commit: 42528eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 10:00pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 1, 2025 10:00pm
login ⬜️ Skipped (Inspect) Apr 1, 2025 10:00pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 1, 2025 10:00pm
wallet-ui ⬜️ Skipped (Inspect) Apr 1, 2025 10:00pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 1, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 1, 2025
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.92%. Comparing base (2606da6) to head (42528eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6617   +/-   ##
=======================================
  Coverage   54.92%   54.92%           
=======================================
  Files         885      885           
  Lines       55577    55577           
  Branches     3792     3792           
=======================================
  Hits        30527    30527           
  Misses      24955    24955           
  Partials       95       95           
Flag Coverage Δ
packages 54.92% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.61 KB (0%) 953 ms (0%) 191 ms (+105.95% 🔺) 1.2 s
thirdweb (cjs) 127.63 KB (0%) 2.6 s (0%) 288 ms (+24.09% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 86 ms (+951.79% 🔺) 198 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 26 ms (+582.71% 🔺) 36 ms
thirdweb/react (minimal + tree-shaking) 19.35 KB (0%) 388 ms (0%) 102 ms (+335.74% 🔺) 489 ms

@gregfromstl gregfromstl merged commit 04943d7 into main Apr 1, 2025
33 checks passed
@gregfromstl gregfromstl deleted the greg/tool-3897-add-search-by-token-symbol-to-routes-page branch April 1, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants