Dashboard: Fix timestamp ordering in various charts, migrate them to use ThirdwebBarChart #6636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6636 +/- ##
=======================================
Coverage 54.98% 54.98%
=======================================
Files 888 888
Lines 55753 55753
Branches 3816 3816
=======================================
Hits 30653 30653
Misses 25005 25005
Partials 95 95
🚀 New features to boost your workflow:
|
Contributor
size-limit report 📦
|
MananTank
force-pushed
the
04-03-dashboard_fix_timestamp_ordering_in_various_charts_migrate_them_to_use_thirdwebbarchart
branch
from
28d6015 to
9dc7e91
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
apps/dashboard/src/components/smart-wallets/AccountAbstractionAnalytics/storyUtils.ts
Show resolved
Hide resolved
joaquim-verges
approved these changes
Apr 3, 2025
Contributor
Merge activity
|
…use ThirdwebBarChart (#6636) <!-- start pr-codex --> ## PR-Codex overview This PR primarily focuses on updating various components to improve chart functionalities and data handling in the dashboard, including the introduction of the `ThirdwebBarChart`. It also refines date handling and enhances the user interface for better data representation. ### Detailed summary - Updated date handling in `stubbedData` from February to December. - Introduced `BadgeContainer` for displaying time ranges in `TotalSponsoredChartCard`. - Enhanced `searchParams` structure in the analytics page to include `from` and `to` dates. - Added `customHeader`, `toolTipValueFormatter`, and `emptyChartState` to `ThirdwebBarChart`. - Replaced `BarChart` with `ThirdwebBarChart` in multiple components for consistency. - Improved data mapping and sorting in `TotalSponsoredChartCard`. - Created new stubs for `EcosystemWalletUsersChartCard` to simulate user data over various days. - Refactored empty state components to improve user guidance when no data is available. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
04-03-dashboard_fix_timestamp_ordering_in_various_charts_migrate_them_to_use_thirdwebbarchart
branch
from
9dc7e91 to
1e092a7
Compare
graphite-app
bot
deleted the
04-03-dashboard_fix_timestamp_ordering_in_various_charts_migrate_them_to_use_thirdwebbarchart
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving various components related to analytics in the dashboard, including date handling, chart configurations, and UI enhancements for better data representation.
Detailed summary
storyUtils.ts.BadgeContainerinTotalSponsoredChartCard.stories.tsx.page.tsxfor date ranges.ThirdwebBarChartproperties for better tooltip formatting.BarChartwithThirdwebBarChartin multiple components, improving chart rendering.TotalSponsoredChartCard.EcosystemWalletUsersChartCardshowcasing various states.