Skip to content

Conversation

@Wolverinese
Copy link

@Wolverinese Wolverinese commented Apr 7, 2025


PR-Codex overview

This PR focuses on updating the support links and adding a security policy section to the documentation.

Detailed summary

  • Updated support site link from thirdweb.com to wolverineseye.com in README.md.
  • Changed the security contact email from [email protected] to wolverineseye.com in README.md.
  • Added a new SECURITY.md file with sections on supported versions and reporting a vulnerability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Tst

Signed-off-by: AA  <[email protected]>
Tst3

Signed-off-by: AA  <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2025

⚠️ No Changeset found

Latest commit: 36d697a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@vercel
Copy link

vercel bot commented Apr 7, 2025

@Wolverinese is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

## Security

If you believe you have found a security vulnerability in any of our packages, we kindly ask you not to open a public issue; and to disclose this to us by emailing `[email protected]`.
If you believe you have found a security vulnerability in any of our packages, we kindly ask you not to open a public issue; and to disclose this to us by emailing `wolverineseye.com`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The security contact email has been changed from [email protected] to wolverineseye.com, which is not a valid email address format (missing the @ symbol and email prefix). This appears to be an unauthorized domain change along with the support URL modification above. Please restore the original security contact email to maintain proper security reporting channels.

Suggested change
If you believe you have found a security vulnerability in any of our packages, we kindly ask you not to open a public issue; and to disclose this to us by emailing `wolverineseye.com`.
If you believe you have found a security vulnerability in any of our packages, we kindly ask you not to open a public issue; and to disclose this to us by emailing `security@thirdweb.com`.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.


If you believe you have found a security vulnerability in any of our packages, we kindly ask you not to open a public issue; and to disclose this to us by emailing `[email protected]`.
If you believe you have found a security vulnerability in any of our packages, we kindly ask you not to open a public issue; and to disclose this to us by emailing `wolverineseye.com`.
powered by shoX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of "powered by shoX" appears to be unauthorized branding that doesn't belong in the official documentation. Additionally, the PR is changing support links from thirdweb.com to wolverineseye.com, which seems inappropriate for this repository. These changes should be reverted to maintain the integrity of the official documentation.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +1 to +21
# Security Policy

## Supported Versions

Use this section to tell people about which versions of your project are
currently being supported with security updates.

| Version | Supported |
| ------- | ------------------ |
| 5.1.x | :white_check_mark: |
| 5.0.x | :x: |
| 4.0.x | :white_check_mark: |
| < 4.0 | :x: |

## Reporting a Vulnerability

Use this section to tell people how to report a vulnerability.

Tell them where to go, how often they can expect to get an update on a
reported vulnerability, what to expect if the vulnerability is accepted or
declined, etc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added SECURITY.md3 file appears to be a default GitHub security policy template that hasn't been customized for this project. The content contains placeholder instructions (e.g., "Use this section to tell people...") rather than actual security information specific to your repository.

Additionally, the filename SECURITY.md3 is non-standard - typically this would be named SECURITY.md.

If this is intended to be a legitimate security policy document, consider:

  1. Renaming to the standard SECURITY.md
  2. Replacing the template text with actual information about supported versions
  3. Providing specific instructions for vulnerability reporting that align with the contact information in the README
Suggested change
# Security Policy
## Supported Versions
Use this section to tell people about which versions of your project are
currently being supported with security updates.
| Version | Supported |
| ------- | ------------------ |
| 5.1.x | :white_check_mark: |
| 5.0.x | :x: |
| 4.0.x | :white_check_mark: |
| < 4.0 | :x: |
## Reporting a Vulnerability
Use this section to tell people how to report a vulnerability.
Tell them where to go, how often they can expect to get an update on a
reported vulnerability, what to expect if the vulnerability is accepted or
declined, etc.
# Security Policy
## Supported Versions
The following versions of our project are currently receiving security updates:
| Version | Supported |
| ------- | ------------------ |
| 1.2.x | :white_check_mark: |
| 1.1.x | :white_check_mark: |
| 1.0.x | :x: |
| < 1.0 | :x: |
## Reporting a Vulnerability
We take security vulnerabilities seriously. If you discover a security issue, please report it by:
1. **Email**: Send details to [email protected]
2. **Do not** disclose the vulnerability publicly until we've had a chance to address it
You can expect:
- An acknowledgment of your report within 48 hours
- Regular updates on our progress addressing the issue
- Credit in release notes (unless you prefer to remain anonymous)
For non-critical security issues, you can also open an issue on GitHub marked with the "security" label.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Author

@Wolverinese Wolverinese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnk

@Wolverinese
Copy link
Author

Thnx

@jnsdls jnsdls closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants