Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 7, 2025

PR-Codex overview

This PR focuses on enhancing the UI components and improving the layout of the dashboard, particularly in the NFT display section. It introduces new components and modifies existing ones for better styling and functionality.

Detailed summary

  • Changed h1 class from font-semibold to font-bold.
  • Replaced Card component with a div for NftProperty.
  • Added ToolTipLabel around Button in TabButtons.
  • Introduced Badge and Breadcrumb components in TokenIdPage.
  • Updated NFTName and NFTDescription styling.
  • Added IPFSLinkGroup component for handling IPFS links.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 4:44pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 7, 2025 4:44pm
login ⬜️ Skipped (Inspect) Apr 7, 2025 4:44pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 7, 2025 4:44pm
wallet-ui ⬜️ Skipped (Inspect) Apr 7, 2025 4:44pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 7, 2025 16:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 7, 2025 16:21 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 7, 2025 16:21 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 7, 2025 16:21 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2025

⚠️ No Changeset found

Latest commit: 1dae74b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 7, 2025
@MananTank MananTank marked this pull request as ready for review April 7, 2025 16:21
@MananTank MananTank requested review from a team as code owners April 7, 2025 16:21
Copy link
Member Author

MananTank commented Apr 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.05%. Comparing base (672f7d0) to head (1dae74b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6665   +/-   ##
=======================================
  Coverage   55.05%   55.05%           
=======================================
  Files         889      889           
  Lines       55858    55858           
  Branches     3825     3825           
=======================================
  Hits        30751    30751           
  Misses      25012    25012           
  Partials       95       95           
Flag Coverage Δ
packages 55.05% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MananTank MananTank force-pushed the 04-07-dashboard_update_nft_token_details_page_styles_reduce_chakra_usage branch from 93898cd to 558eaeb Compare April 7, 2025 16:24
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 7, 2025 16:24 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 7, 2025 16:24 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 7, 2025 16:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 7, 2025 16:24 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.62 KB (0%) 953 ms (0%) 141 ms (+191.17% 🔺) 1.1 s
thirdweb (cjs) 129.82 KB (0%) 2.6 s (0%) 187 ms (+19.03% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 74 ms (+1459.44% 🔺) 187 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 44 ms (+2666.95% 🔺) 54 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 92 ms (+651.01% 🔺) 479 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 7, 2025

Merge activity

…6665)

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on improving the UI components of the dashboard, enhancing the styling and structure of various elements, and adding new features like tooltips and breadcrumbs for better navigation.

### Detailed summary
- Changed `className` from `font-semibold` to `font-bold` in the `h1` element.
- Updated `NftProperty` component to use `div` instead of `Card`.
- Added `toolTip` property to `TabButtons`.
- Wrapped `Button` in `ToolTipLabel` for tooltips.
- Introduced `IPFSLinkGroup` component for displaying IPFS links.
- Enhanced `NFTName` and `NFTDescription` styling.
- Removed unnecessary imports and unused variables for cleaner code.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-07-dashboard_update_nft_token_details_page_styles_reduce_chakra_usage branch from 558eaeb to 1dae74b Compare April 7, 2025 16:38
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 7, 2025 16:38 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 7, 2025 16:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 7, 2025 16:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 7, 2025 16:38 Inactive
@graphite-app graphite-app bot merged commit 1dae74b into main Apr 7, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 04-07-dashboard_update_nft_token_details_page_styles_reduce_chakra_usage branch April 7, 2025 16:45
@vercel vercel bot temporarily deployed to Production – login April 7, 2025 16:45 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 7, 2025 16:45 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 7, 2025 16:45 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 7, 2025 16:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants