Update deploy config #6667
Merged
Update deploy config #6667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
kumaryash90
added
the
DO NOT MERGE
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6667 +/- ##
==========================================
- Coverage 55.05% 55.04% -0.01%
==========================================
Files 889 889
Lines 55858 55862 +4
Branches 3823 3824 +1
==========================================
+ Hits 30751 30752 +1
- Misses 25012 25016 +4
+ Partials 95 94 -1
🚀 New features to boost your workflow:
|
Contributor
size-limit report 📦
|
kumaryash90
removed
the
DO NOT MERGE
| // force `ipfs://` prefix | ||
| uri: publishedContractNoFee?.publishMetadataUri.startsWith("ipfs://") | ||
| ? publishedContractNoFee.publishMetadataUri | ||
| : `ipfs://${publishedContractNoFee?.publishMetadataUri}`, |
Member
There was a problem hiding this comment.
this looks wrong? you're fetching the same thing twice
Member
Author
There was a problem hiding this comment.
this second one is the hardcoded version metadata for specific cases.
first one is latest or given version metadata, as default.
joaquim-verges
approved these changes
Apr 9, 2025
kumaryash90
added
the
merge-queue
Member
Author
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces support for contracts that have no fees by adding new properties and constants to handle fee exemption logic. It modifies several components to utilize the new metadata and fee configurations, ensuring that contracts can be deployed without fees based on specific versions and chains.
### Detailed summary
- Added `contractMetadataNoFee` prop to `DeployFormForUri` and `CustomContractForm`.
- Introduced `ZERO_FEE_VERSIONS` and `ZERO_FEE_CHAINS` constants in `fee-config.ts`.
- Updated `DeployFormForPublishInfo` to fetch metadata for contracts without fees.
- Adjusted fee logic in `CustomContractForm` to use `ZERO_FEE_CHAINS`.
- Modified deployment logic to conditionally use fee-exempt metadata.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
yash/deploy-config-updates-4
branch
from
6624214 to
a230532
Compare
graphite-app
bot
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces support for contracts with zero fees by adding new metadata properties and configurations. It modifies the deployment forms to handle both fee and no-fee contracts, ensuring that the fee structure is applied correctly based on the contract version and chain.
Detailed summary
contractMetadataNoFeeprop toDeployFormForUri.ZERO_FEE_VERSIONSandZERO_FEE_CHAINSconstants infee-config.ts.DeployFormForUriPropsto includecontractMetadataNoFee.DeployFormForUrito fetch and usecontractMetadataNoFee.DeployFormForPublishInfoto find and handle no-fee versions.CustomContractFormto utilizemetadataNoFeewhen applicable.ZERO_FEE_CHAINSfor fee exemptions.