Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 10, 2025


PR-Codex overview

This PR introduces an extra gas buffer for transaction requests in the buyWithCrypto functionality of the thirdweb package.

Detailed summary

  • Added an extraGas property with a value of 50000n in the getQuote.ts file for transaction requests.
  • Added an extraGas property with a value of 50000n in the getTransfer.ts file for transaction requests.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 9:13pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 9:13pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 9:13pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 9:13pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 9:13pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025

🦋 Changeset detected

Latest commit: 11f30dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 10, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.69 KB (+0.07% 🔺) 954 ms (+0.07% 🔺) 189 ms (+66.03% 🔺) 1.2 s
thirdweb (cjs) 130.01 KB (+0.06% 🔺) 2.7 s (+0.06% 🔺) 305 ms (+22.27% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 83 ms (+1165.7% 🔺) 196 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 56 ms (+1869.04% 🔺) 66 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 103 ms (+485.27% 🔺) 490 ms

@joaquim-verges joaquim-verges merged commit c1d6bb7 into main Apr 10, 2025
29 of 32 checks passed
@joaquim-verges joaquim-verges deleted the _Pay_Add_extra_gas_buffer_for_quote_and_transfer_transactions branch April 10, 2025 21:10
@joaquim-verges joaquim-verges mentioned this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants