Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 13, 2025


PR-Codex overview

This PR focuses on improving error handling in the eip1193 connector by preventing retries when a user connection is rejected.

Detailed summary

  • Added a check to throw an error if the rejection message from the user is detected in the catch block.
  • Introduced a new function, extractErrorMessage, to standardize error message extraction from various error types.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2025

🦋 Changeset detected

Latest commit: fae6312

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 13, 2025
@joaquim-verges joaquim-verges changed the title Don't retry on user connection rejection in EIP1193 connector [SDK] Don't retry on user connection rejection in EIP1193 connector Apr 13, 2025
@vercel
Copy link

vercel bot commented Apr 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2025 11:49pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2025 11:49pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2025 11:49pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2025 11:49pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2025 11:49pm

@joaquim-verges joaquim-verges marked this pull request as ready for review April 13, 2025 23:41
@joaquim-verges joaquim-verges requested review from a team as code owners April 13, 2025 23:41
Copy link
Member Author

joaquim-verges commented Apr 13, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.67 KB (0%) 954 ms (0%) 181 ms (+177.41% 🔺) 1.2 s
thirdweb (cjs) 130.06 KB (0%) 2.7 s (0%) 251 ms (+55.48% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 61 ms (+1054.59% 🔺) 173 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 63 ms (+1358.34% 🔺) 74 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 102 ms (+765.61% 🔺) 489 ms

@codecov
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 55.01%. Comparing base (fa0d114) to head (fae6312).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/wallets/injected/index.ts 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6712      +/-   ##
==========================================
- Coverage   55.02%   55.01%   -0.01%     
==========================================
  Files         889      889              
  Lines       55889    55904      +15     
  Branches     3821     3824       +3     
==========================================
+ Hits        30754    30758       +4     
- Misses      25040    25051      +11     
  Partials       95       95              
Flag Coverage Δ
packages 55.01% <0.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/injected/index.ts 36.51% <0.00%> (-1.98%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit e574114 into main Apr 14, 2025
34 of 35 checks passed
@joaquim-verges joaquim-verges deleted the Don_t_retry_on_user_connection_rejection_in_EIP1193_connector branch April 14, 2025 00:28
@joaquim-verges joaquim-verges mentioned this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants