[SDK] Fix: Error message cleanup on UB embed #6716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: tool-4077
gregfromstl
added
the
merge-queue
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2cf63bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
Merge activity
|
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/swap/ConfirmationScreen.tsx
Outdated
Show resolved
Hide resolved
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (8.27%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6716 +/- ##
==========================================
- Coverage 55.02% 54.92% -0.11%
==========================================
Files 889 890 +1
Lines 55889 56002 +113
Branches 3820 3821 +1
==========================================
+ Hits 30753 30757 +4
- Misses 25041 25150 +109
Partials 95 95
🚀 New features to boost your workflow:
|
joaquim-verges
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: tool-4077
PR-Codex overview
This PR focuses on improving error handling and user notifications in the
thirdwebwallet interface, enhancing the user experience during transactions by providing clearer error messages and updating UI elements for consistency.Detailed summary
Stepper.tsx.ErrorTextcomponent.getErrorMessagefunction.FiatScreenContent,SwapScreenContent, andTransferConfirmationScreencomponents.uiErrorMessagelogic to handle errors inTransferConfirmationScreenandSwapConfirmationScreen.