Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 14, 2025

Fixes TOOL-4007


PR-Codex overview

This PR focuses on enhancing the analytics functionality for ecosystem wallets by adding a new property to the wallet stats interface and improving the data fetching and display logic to include partner information.

Detailed summary

  • Added ecosystemPartnerId to the EcosystemWalletStats interface.
  • Updated API endpoint in fetchAnalytics to use v2/wallet/connects.
  • Enhanced error logging with detailed response information.
  • Fetched partners in the Page component.
  • Passed partners to EcosystemAnalyticsPage.
  • Updated EcosystemAnalyticsPage to accept partners and group data by ecosystemPartnerId or authenticationMethod.
  • Modified EcosystemWalletUsersChartCard to handle grouping by ecosystemPartnerId.
  • Adjusted storybook stories to include groupBy for various data scenarios.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 14, 2025 04:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 14, 2025 04:59 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 14, 2025 04:59 Inactive
@vercel
Copy link

vercel bot commented Apr 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 5:12am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 14, 2025 5:12am
login ⬜️ Skipped (Inspect) Apr 14, 2025 5:12am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 14, 2025 5:12am
wallet-ui ⬜️ Skipped (Inspect) Apr 14, 2025 5:12am

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 14, 2025 04:59 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025

⚠️ No Changeset found

Latest commit: 9c67f29

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 14, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review April 14, 2025 05:00
@linear
Copy link

linear bot commented Apr 14, 2025

@joaquim-verges joaquim-verges requested review from a team as code owners April 14, 2025 05:00
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.92%. Comparing base (0ea8987) to head (9c67f29).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6717   +/-   ##
=======================================
  Coverage   54.92%   54.92%           
=======================================
  Files         890      890           
  Lines       56002    56002           
  Branches     3821     3821           
=======================================
  Hits        30757    30757           
  Misses      25150    25150           
  Partials       95       95           
Flag Coverage Δ
packages 54.92% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.67 KB (0%) 954 ms (0%) 248 ms (+86.83% 🔺) 1.3 s
thirdweb (cjs) 130.06 KB (0%) 2.7 s (0%) 389 ms (-9.59% 🔽) 3 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 29 ms (+182.05% 🔺) 141 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 40 ms (+996.28% 🔺) 50 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 111 ms (+203.3% 🔺) 498 ms

@joaquim-verges joaquim-verges force-pushed the _Dashboard_Add_partner-based_analytics_for_ecosystem_wallet_usage branch from b3f64b5 to 9c67f29 Compare April 14, 2025 05:05
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 14, 2025 05:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 14, 2025 05:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 14, 2025 05:05 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 14, 2025 05:05 Inactive
@joaquim-verges joaquim-verges merged commit cd30ba4 into main Apr 14, 2025
33 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_Add_partner-based_analytics_for_ecosystem_wallet_usage branch April 14, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants