Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Apr 14, 2025

Add Warning for Teams with Invalid Payment Methods

This PR adds a warning message for teams with invalid payment methods, preventing them from upgrading plans until they resolve outstanding invoices.

Changes:

  • Added a warning component that displays when a team has an invalidPayment billing status
  • Added a filter to view only open invoices in the invoices page
  • Updated the getTeamInvoices function to accept an optional status parameter
  • Disabled checkout buttons for teams with invalid payment methods
  • Added a warning in the cancel plan modal for teams with unpaid invoices
  • Added a link to direct users to pay their outstanding invoices

These changes help users understand why they can't upgrade their plan and guides them to resolve payment issues.


PR-Codex overview

This PR enhances billing and invoice management features, adding filters and improving user notifications regarding invoice statuses. It also integrates billing status checks into various components for better user experience.

Detailed summary

  • Added billingStatus prop to multiple components.
  • Implemented BillingFilter for invoice status selection.
  • Enhanced BillingHistory to display messages for no open invoices.
  • Updated CancelPlanButton to show warnings for unpaid invoices.
  • Modified CheckoutButton to display a warning for invalid payment methods.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 2:26pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 14, 2025 2:26pm
login ⬜️ Skipped (Inspect) Apr 14, 2025 2:26pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 14, 2025 2:26pm
wallet-ui ⬜️ Skipped (Inspect) Apr 14, 2025 2:26pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 14, 2025 12:58 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 14, 2025 12:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 14, 2025 12:58 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 14, 2025 12:58 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025

⚠️ No Changeset found

Latest commit: 7682298

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 14, 2025
Copy link
Member Author

jnsdls commented Apr 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.93%. Comparing base (52261a5) to head (7682298).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6718   +/-   ##
=======================================
  Coverage   54.93%   54.93%           
=======================================
  Files         890      890           
  Lines       56002    56002           
  Branches     3820     3820           
=======================================
  Hits        30762    30762           
  Misses      25145    25145           
  Partials       95       95           
Flag Coverage Δ
packages 54.93% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.67 KB (0%) 954 ms (0%) 239 ms (+274.38% 🔺) 1.2 s
thirdweb (cjs) 130.06 KB (0%) 2.7 s (0%) 321 ms (+100.56% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 121 ms (+2069.86% 🔺) 234 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 34 ms (+1917.48% 🔺) 44 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 98 ms (+670.49% 🔺) 485 ms

@jnsdls jnsdls marked this pull request as ready for review April 14, 2025 13:03
@jnsdls jnsdls requested review from a team as code owners April 14, 2025 13:03
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 14, 2025

Merge activity

# Add Warning for Teams with Invalid Payment Methods

This PR adds a warning message for teams with invalid payment methods, preventing them from upgrading plans until they resolve outstanding invoices.

## Changes:

- Added a warning component that displays when a team has an `invalidPayment` billing status
- Added a filter to view only open invoices in the invoices page
- Updated the `getTeamInvoices` function to accept an optional `status` parameter
- Disabled checkout buttons for teams with invalid payment methods
- Added a warning in the cancel plan modal for teams with unpaid invoices
- Added a link to direct users to pay their outstanding invoices

These changes help users understand why they can't upgrade their plan and guides them to resolve payment issues.
@graphite-app graphite-app bot force-pushed the Add_billing_warning_and_open_invoice_filtering branch from 2b83d5e to 7682298 Compare April 14, 2025 14:19
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 14, 2025 14:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 14, 2025 14:20 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 14, 2025 14:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 14, 2025 14:20 Inactive
@graphite-app graphite-app bot merged commit 7682298 into main Apr 14, 2025
32 checks passed
@graphite-app graphite-app bot deleted the Add_billing_warning_and_open_invoice_filtering branch April 14, 2025 14:27
@vercel vercel bot temporarily deployed to Production – docs-v2 April 14, 2025 14:27 Inactive
@vercel vercel bot temporarily deployed to Production – login April 14, 2025 14:27 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 14, 2025 14:27 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 14, 2025 14:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants