Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 15, 2025

Fixes TOOL-4118


PR-Codex overview

This PR focuses on improving error handling in various parts of the codebase by enhancing error messages when requests fail. It captures additional details such as status and status text, providing clearer context for debugging.

Detailed summary

  • Improved error messages in packages/thirdweb/src/transaction/actions/gasless/providers/biconomy.ts and openzeppelin.ts.
  • Enhanced error logging in apps/wallet-ui/src/lib/assets/erc721.ts and chains.ts.
  • Updated error handling in multiple files within packages/thirdweb/src/pay/ and packages/thirdweb/src/rpc/.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2025

🦋 Changeset detected

Latest commit: 6794c88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 7:35pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 7:35pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 7:35pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 7:35pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 7:35pm

@github-actions github-actions bot added packages Ecosystem Portal Involves changes to the Ecosystem Portal SDK Involves changes to the thirdweb SDK labels Apr 15, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title Improve error messages for failed HTTP requests [SDK] Improve error messages for failed HTTP requests Apr 15, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review April 15, 2025 19:27
@joaquim-verges joaquim-verges requested review from a team as code owners April 15, 2025 19:27
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.42 KB (+0.19% 🔺) 1.1 s (+0.19% 🔺) 235 ms (+151.58% 🔺) 1.3 s
thirdweb (cjs) 136.84 KB (-0.05% 🔽) 2.8 s (-0.05% 🔽) 345 ms (+35.66% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.64 KB (+0.02% 🔺) 113 ms (+0.02% 🔺) 97 ms (+895.27% 🔺) 210 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 68 ms (+3037.51% 🔺) 78 ms
thirdweb/react (minimal + tree-shaking) 19.4 KB (+0.22% 🔺) 388 ms (+0.22% 🔺) 114 ms (+472.53% 🔺) 502 ms

@linear
Copy link

linear bot commented Apr 15, 2025

@joaquim-verges joaquim-verges merged commit 2a7df33 into main Apr 15, 2025
22 of 23 checks passed
@joaquim-verges joaquim-verges deleted the Improve_error_messages_for_failed_HTTP_requests branch April 15, 2025 19:43
@joaquim-verges joaquim-verges mentioned this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ecosystem Portal Involves changes to the Ecosystem Portal packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants