Fix RPC usage graphs and improve rate limit visualization #6737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6737 +/- ##
=======================================
Coverage 54.80% 54.80%
=======================================
Files 895 895
Lines 56384 56384
Branches 3850 3850
=======================================
Hits 30899 30899
Misses 25390 25390
Partials 95 95
🚀 New features to boost your workflow:
|
jnsdls
force-pushed
the
Fix_RPC_usage_graphs_and_improve_rate_limit_visualization
branch
from
d74d78a to
1b941b3
Compare
Contributor
size-limit report 📦
|
MananTank
approved these changes
Apr 15, 2025
joaquim-verges
approved these changes
Apr 15, 2025
jnsdls
force-pushed
the
Fix_RPC_usage_graphs_and_improve_rate_limit_visualization
branch
from
1b941b3 to
a49d8d0
Compare
Contributor
Merge activity
|
# Improve RPC Usage Graphs
This PR enhances the RPC usage graphs in the dashboard:
- Only show rate limited requests in the legend when there are actually rate limited requests
- Fix data processing by removing the `.slice(1, -1)` which was incorrectly trimming data points
- Ensure numeric values by explicitly converting to Number
- Move data slicing to the parent component for better control
- Add a type assertion comment to handle the TypeScript warning
- Add a check to conditionally display relevant chart configuration
These changes improve the accuracy and presentation of the RPC usage data visualization.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `CountGraph` component by improving the handling of rate-limited data and formatting the `currentRateLimit` value for better readability.
### Detailed summary
- Updated the `currentRateLimit` display to use `toLocaleString()`.
- Added a check for `hasAnyRateLimited` to conditionally configure the chart.
- Modified the `config` object to include `rateLimitedCount` only if there are any rate-limited requests.
- Converted `includedCount` and `rateLimitedCount` to `Number` type during data mapping.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
Fix_RPC_usage_graphs_and_improve_rate_limit_visualization
branch
from
a49d8d0 to
baf95b9
Compare
graphite-app
bot
deleted the
Fix_RPC_usage_graphs_and_improve_rate_limit_visualization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve RPC Usage Graphs
This PR enhances the RPC usage graphs in the dashboard:
.slice(1, -1)which was incorrectly trimming data pointsThese changes improve the accuracy and presentation of the RPC usage data visualization.
PR-Codex overview
This PR focuses on improving the
CountGraphcomponent by enhancing data handling and display logic, specifically related to rate limits and formatting of the current rate limit.Detailed summary
currentRateLimitdisplay to usetoLocaleString().hasAnyRateLimitedto check for rate-limited requests.configto conditionally includerateLimitedCountbased onhasAnyRateLimited.includedCountandrateLimitedCountin data mapping.