-
Notifications
You must be signed in to change notification settings - Fork 621
[SDK] Use insight for erc721/getNFTs and erc721/getOwnedNFTs #6741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Use insight for erc721/getNFTs and erc721/getOwnedNFTs #6741
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 898404a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
3ea6090 to
ac06a55
Compare
size-limit report 📦
|
ac06a55 to
26f2563
Compare
26f2563 to
abc2306
Compare
abc2306 to
56a49d7
Compare
c778894 to
2f018ec
Compare
6d01404 to
be7fcb3
Compare
f4d7004 to
c261d9a
Compare
c261d9a to
898404a
Compare
| // Exponential backoff: 2^(retries + 1) * 200ms (400ms, 800ms, 1600ms) | ||
| const delay = 2 ** (retries + 1) * 200; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exponential backoff calculation is correct, but the comment's example values don't match the actual implementation. For retries=0, the delay would be 2^(0+1) * 200ms = 400ms, for retries=1 it would be 2^2 * 200ms = 800ms, and for retries=2 it would be 2^3 * 200ms = 1600ms. The comment should accurately reflect these values.
| // Exponential backoff: 2^(retries + 1) * 200ms (400ms, 800ms, 1600ms) | |
| const delay = 2 ** (retries + 1) * 200; | |
| // Exponential backoff: 2^(retries + 1) * 200ms (retries=0: 400ms, retries=1: 800ms, retries=2: 1600ms) | |
| const delay = 2 ** (retries + 1) * 200; |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (65.88%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6741 +/- ##
==========================================
+ Coverage 54.80% 55.09% +0.29%
==========================================
Files 895 896 +1
Lines 56384 56714 +330
Branches 3850 3911 +61
==========================================
+ Hits 30899 31246 +347
+ Misses 25390 25372 -18
- Partials 95 96 +1
🚀 New features to boost your workflow:
|

PR-Codex overview
This PR enhances the NFT functionality by integrating an insight API for fetching NFT data across various extensions, allowing for improved performance and reliability when retrieving NFT information.
Detailed summary
tokenAddressandchainIdfields to multiple NFT-related functions.getNFT,getNFTs, andgetOwnedNFTs.