Skip to content

Conversation

@jakeloo
Copy link
Member

@jakeloo jakeloo commented Apr 16, 2025


PR-Codex overview

This PR removes the logic that checks for teams with "nebula" access and the associated waitlist page rendering if no teams have access.

Detailed summary

  • Removed the teamWithNebulaAccess variable and its associated logic.
  • Eliminated the conditional rendering of the NebulaWaitlistPage when no teams have "nebula" access.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 0:20am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 16, 2025 0:20am
login ⬜️ Skipped (Inspect) Apr 16, 2025 0:20am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 16, 2025 0:20am
wallet-ui ⬜️ Skipped (Inspect) Apr 16, 2025 0:20am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 16, 2025 00:20 Inactive
@jakeloo jakeloo requested review from a team as code owners April 16, 2025 00:20
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025

⚠️ No Changeset found

Latest commit: 6d03493

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 16, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 16, 2025
@jakeloo jakeloo added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Apr 16, 2025
@jakeloo jakeloo closed this Apr 16, 2025
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (64bd603) to head (6d03493).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6742   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files         895      895           
  Lines       56384    56384           
  Branches     3850     3850           
=======================================
  Hits        30899    30899           
  Misses      25390    25390           
  Partials       95       95           
Flag Coverage Δ
packages 54.80% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.42 KB (0%) 1.1 s (0%) 216 ms (+137.33% 🔺) 1.3 s
thirdweb (cjs) 136.84 KB (0%) 2.8 s (0%) 317 ms (+18.83% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.64 KB (0%) 113 ms (0%) 89 ms (+1209.49% 🔺) 202 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 57 ms (+1557.48% 🔺) 67 ms
thirdweb/react (minimal + tree-shaking) 19.4 KB (0%) 388 ms (0%) 90 ms (+449.36% 🔺) 478 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. DO NOT MERGE This pull request is still in progress and is not ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants