Skip to content

Conversation

@GiselleNessi
Copy link
Contributor

@GiselleNessi GiselleNessi commented Apr 16, 2025


PR-Codex overview

This PR focuses on enhancing the TeamProjectsPage by adding a new ShareButton component for inviting team members and integrating analytics tracking for button clicks.

Detailed summary

  • Added useTrack hook for analytics tracking.
  • Introduced ShareButton component for inviting team members.
  • Wrapped ShareButton in a Link to navigate to the team members settings.
  • Updated imports to include UserPlus icon.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@GiselleNessi GiselleNessi self-assigned this Apr 16, 2025
@GiselleNessi GiselleNessi requested review from a team as code owners April 16, 2025 22:50
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025

⚠️ No Changeset found

Latest commit: 9091e81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 5:30am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 17, 2025 5:30am
login ⬜️ Skipped (Inspect) Apr 17, 2025 5:30am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 17, 2025 5:30am
wallet-ui ⬜️ Skipped (Inspect) Apr 17, 2025 5:30am

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 16, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 16, 2025
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.10%. Comparing base (23d3757) to head (9091e81).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6751   +/-   ##
=======================================
  Coverage   55.10%   55.10%           
=======================================
  Files         896      896           
  Lines       56700    56700           
  Branches     3914     3914           
=======================================
  Hits        31247    31247           
  Misses      25357    25357           
  Partials       96       96           
Flag Coverage Δ
packages 55.10% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.57 KB (0%) 1.1 s (0%) 86 ms (+174.98% 🔺) 1.1 s
thirdweb (cjs) 138.73 KB (0%) 2.8 s (0%) 128 ms (+82.02% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 56 ms (+2567.26% 🔺) 168 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 34 ms (+2016.36% 🔺) 44 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 77 ms (+1223.17% 🔺) 464 ms

Copy link
Contributor Author

GiselleNessi commented Apr 16, 2025

Merge activity

  • Apr 16, 7:53 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 16, 7:57 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 17, 1:20 AM EDT: GiselleNessi added this pull request to the Graphite merge queue.
  • Apr 17, 1:31 AM EDT: Merged by the Graphite merge queue.

>
<UserPlus className="size-4" />
<span>
<span className="hidden lg:inline">Invite</span> Team
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Invite Team" sounds weird. Do you mean "Invite to team"? or just "Invite"?

  • + Team
  • + Invite Team
  • + Invite
  • + Invite to Team

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 17, 2025 05:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 17, 2025 05:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 17, 2025 05:12 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 17, 2025 05:12 Inactive
>
<UserPlus className="size-4" />
<span>
<span className="hidden lg:inline">Invite</span>to Team
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a missing space between "Invite" and "to Team" in the text content, which will render as "InvitetoTeam" in the UI. Adding a space after </span> would fix this display issue:

<span className="hidden lg:inline">Invite</span> to Team
Suggested change
<span className="hidden lg:inline">Invite</span>to Team
<span className="hidden lg:inline">Invite</span> to Team

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new `ShareButton` component to the `TeamProjectsPage`, allowing users to invite team members. It also tracks the button click event for analytics and includes a link to the team members settings.

### Detailed summary
- Added `ShareButton` component for inviting team members.
- Integrated `useTrack` hook to track button click events.
- Added a link to the team members settings using `Link`.
- Imported `UserPlus` icon from `lucide-react`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the gi/invite-team-button branch from 032c922 to 9091e81 Compare April 17, 2025 05:21
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 17, 2025 05:21 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 17, 2025 05:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 17, 2025 05:21 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 17, 2025 05:21 Inactive
@graphite-app graphite-app bot merged commit 9091e81 into main Apr 17, 2025
23 checks passed
@graphite-app graphite-app bot deleted the gi/invite-team-button branch April 17, 2025 05:31
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Apr 17, 2025
@vercel vercel bot temporarily deployed to Production – wallet-ui April 17, 2025 05:31 Inactive
@vercel vercel bot temporarily deployed to Production – login April 17, 2025 05:31 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 17, 2025 05:31 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 17, 2025 05:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants