-
Notifications
You must be signed in to change notification settings - Fork 621
added invite team button in dash homepage #6751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6751 +/- ##
=======================================
Coverage 55.10% 55.10%
=======================================
Files 896 896
Lines 56700 56700
Branches 3914 3914
=======================================
Hits 31247 31247
Misses 25357 25357
Partials 96 96
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Merge activity
|
| > | ||
| <UserPlus className="size-4" /> | ||
| <span> | ||
| <span className="hidden lg:inline">Invite</span> Team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Invite Team" sounds weird. Do you mean "Invite to team"? or just "Invite"?
- ❌
+ Team - ❌
+ Invite Team - ✅
+ Invite - ✅
+ Invite to Team
| > | ||
| <UserPlus className="size-4" /> | ||
| <span> | ||
| <span className="hidden lg:inline">Invite</span>to Team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a missing space between "Invite" and "to Team" in the text content, which will render as "InvitetoTeam" in the UI. Adding a space after </span> would fix this display issue:
<span className="hidden lg:inline">Invite</span> to Team| <span className="hidden lg:inline">Invite</span>to Team | |
| <span className="hidden lg:inline">Invite</span> to Team |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a new `ShareButton` component to the `TeamProjectsPage`, allowing users to invite team members. It also tracks the button click event for analytics and includes a link to the team members settings.
### Detailed summary
- Added `ShareButton` component for inviting team members.
- Integrated `useTrack` hook to track button click events.
- Added a link to the team members settings using `Link`.
- Imported `UserPlus` icon from `lucide-react`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
032c922 to
9091e81
Compare
PR-Codex overview
This PR focuses on enhancing the
TeamProjectsPageby adding a newShareButtoncomponent for inviting team members and integrating analytics tracking for button clicks.Detailed summary
useTrackhook for analytics tracking.ShareButtoncomponent for inviting team members.ShareButtonin aLinkto navigate to the team members settings.UserPlusicon.