Dashboard: disable prefetch for footer links #6756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
size-limit report 📦
|
MananTank
force-pushed
the
04-17-dashboard_disable_prefetch_for_footer_links
branch
from
b87deda to
27cae28
Compare
jnsdls
approved these changes
Apr 17, 2025
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a new component structure for the `AppFooter` in the `app-footer.tsx` file. It replaces hardcoded footer links with a dynamic array, enhancing maintainability and readability.
### Detailed summary
- Added a `footerLinks` array containing link objects with `href` and `label`.
- Replaced individual `Link` components with a mapped rendering of `FooterLink` components.
- Introduced a new `FooterLink` function component to handle link rendering.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
04-17-dashboard_disable_prefetch_for_footer_links
branch
from
27cae28 to
5a5d7c6
Compare
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR refactors the `AppFooter` component in `app-footer.tsx` by introducing a new `footerLinks` array to manage footer link data and replaces individual `Link` components with a new `FooterLink` function to enhance maintainability and readability.
### Detailed summary
- Added `footerLinks` array containing link objects with `href` and `label`.
- Replaced individual `Link` components with a mapped `FooterLink` component.
- Introduced `FooterLink` function to streamline link rendering and improve code clarity.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
04-17-dashboard_disable_prefetch_for_footer_links
branch
from
5a5d7c6 to
563c4c7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6756 +/- ##
=======================================
Coverage 55.10% 55.10%
=======================================
Files 896 896
Lines 56700 56700
Branches 3914 3914
=======================================
Hits 31247 31247
Misses 25357 25357
Partials 96 96
🚀 New features to boost your workflow:
|
graphite-app
bot
deleted the
04-17-dashboard_disable_prefetch_for_footer_links
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces a new
footerLinksarray to streamline the rendering of footer links in theAppFootercomponent. It replaces hardcodedLinkcomponents with a dynamic mapping of thefooterLinks, enhancing maintainability and readability.Detailed summary
footerLinksarray containing objects withhrefandlabel.Linkcomponents with a mapping offooterLinksto renderFooterLinkcomponents.FooterLinkfunctional component to handle link rendering.