Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 17, 2025


PR-Codex overview

This PR introduces the BuyDirectListingButton component to the ListingDrawer, enabling users to buy listings directly. It updates the documentation and integrates error handling and success notifications using toast.

Detailed summary

  • Updated documentation for BuyDirectListingButton to specify its props.
  • Imported BuyDirectListingButton in listing-drawer.tsx.
  • Added BuyDirectListingButton to render when the listing is active and not owned by the user.
  • Implemented error and success notifications using toast.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Apr 17, 2025

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2025

⚠️ No Changeset found

Latest commit: 24319f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 9:29am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 9:29am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 9:29am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 9:29am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 9:29am

@MananTank MananTank marked this pull request as ready for review April 17, 2025 16:43
@MananTank MananTank requested review from a team as code owners April 17, 2025 16:43
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK labels Apr 17, 2025
Copy link
Member Author

MananTank commented Apr 17, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.75 KB (0%) 1.1 s (0%) 242 ms (+69.84% 🔺) 1.3 s
thirdweb (cjs) 139.02 KB (0%) 2.8 s (0%) 388 ms (+10.58% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 81 ms (+594.61% 🔺) 193 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 16 ms (+144.79% 🔺) 26 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 80 ms (+80.62% 🔺) 467 ms

@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.17%. Comparing base (f38b262) to head (24319f4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6757      +/-   ##
==========================================
- Coverage   55.19%   55.17%   -0.02%     
==========================================
  Files         896      896              
  Lines       56921    56921              
  Branches     3944     3942       -2     
==========================================
- Hits        31416    31407       -9     
- Misses      25409    25418       +9     
  Partials       96       96              
Flag Coverage Δ
packages 55.17% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
...prebuilt/thirdweb/BuyDirectListingButton/index.tsx 44.14% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 18, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Apr 18, 2025
…rketplace (#6757)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `ListingDrawer` component by integrating the `BuyDirectListingButton`, allowing users to buy listings directly from the dashboard.

### Detailed summary
- Updated documentation for `BuyDirectListingButton` in `index.tsx`.
- Imported `BuyDirectListingButton` in `listing-drawer.tsx`.
- Removed a TODO comment regarding the Buy button.
- Added the `BuyDirectListingButton` with props for listing purchase, including error and success handling.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
…rketplace (#6757)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces the `BuyDirectListingButton` component into the `ListingDrawer` component, enhancing the marketplace functionality by allowing users to buy listings directly. It also updates documentation and adds error handling for the transaction process.

### Detailed summary
- Updated documentation for the `BuyDirectListingButton` to specify `BuyDirectListingButtonProps`.
- Imported `BuyDirectListingButton` in `listing-drawer.tsx`.
- Implemented the `BuyDirectListingButton` in the `ListingDrawer` component.
- Added error and success toast notifications for transaction outcomes.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants