Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 18, 2025


PR-Codex overview

This PR adds branding for thirdweb to the PayEmbed UI, enhances the PoweredByThirdweb component, and corrects some type definitions. It also ensures consistent spacing and layout adjustments across various screens.

Detailed summary

  • Added showThirdwebBranding option to enable/disable branding in PayEmbed.
  • Corrected type name from TranasctionOptions to TransactionOptions.
  • Updated the PoweredByThirdweb component to accept an optional link prop.
  • Adjusted spacing with Spacer components in multiple screens.
  • Updated ThirdwebTextIcon height for better aesthetics.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 0:58am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 0:58am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 0:58am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 0:58am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 0:58am

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2025

🦋 Changeset detected

Latest commit: adcb8c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 18, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title Add thirdweb branding to PayEmbed [SDK] Add thirdweb branding to PayEmbed Apr 18, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review April 18, 2025 00:36
@joaquim-verges joaquim-verges requested review from a team as code owners April 18, 2025 00:36
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.75 KB (+0.01% 🔺) 1.1 s (+0.01% 🔺) 259 ms (+149.68% 🔺) 1.3 s
thirdweb (cjs) 138.9 KB (-0.02% 🔽) 2.8 s (-0.02% 🔽) 385 ms (+56.39% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 82 ms (+813.75% 🔺) 194 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 42 ms (+1681.9% 🔺) 52 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 153 ms (+617.71% 🔺) 541 ms

@joaquim-verges joaquim-verges force-pushed the Add_thirdweb_branding_to_PayEmbed branch from f23ba1e to 1b367d5 Compare April 18, 2025 00:42
@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 13.51351% with 32 lines in your changes missing coverage. Please review.

Project coverage is 55.16%. Comparing base (4cf15a2) to head (adcb8c1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 11.11% 8 Missing ⚠️
...nectWallet/screens/Buy/DirectPaymentModeScreen.tsx 11.11% 8 Missing ⚠️
...onnectWallet/screens/Buy/TransactionModeScreen.tsx 11.11% 8 Missing ⚠️
...web/src/react/web/ui/ConnectWallet/PoweredByTW.tsx 12.50% 7 Missing ⚠️
...react/web/hooks/transaction/useSendTransaction.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6760      +/-   ##
==========================================
- Coverage   55.18%   55.16%   -0.02%     
==========================================
  Files         896      896              
  Lines       56881    56910      +29     
  Branches     3941     3940       -1     
==========================================
+ Hits        31389    31396       +7     
- Misses      25395    25419      +24     
+ Partials       97       95       -2     
Flag Coverage Δ
packages 55.16% <13.51%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
packages/thirdweb/src/insight/get-nfts.ts 88.00% <100.00%> (ø)
...react/core/hooks/transaction/useSendTransaction.ts 10.66% <ø> (ø)
...react/web/hooks/transaction/useSendTransaction.tsx 37.03% <0.00%> (-0.70%) ⬇️
...web/src/react/web/ui/ConnectWallet/PoweredByTW.tsx 14.70% <12.50%> (-1.97%) ⬇️
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 4.65% <11.11%> (+0.07%) ⬆️
...nectWallet/screens/Buy/DirectPaymentModeScreen.tsx 10.61% <11.11%> (+0.06%) ⬆️
...onnectWallet/screens/Buy/TransactionModeScreen.tsx 8.98% <11.11%> (+0.08%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 7ecfcb9 into main Apr 18, 2025
22 of 24 checks passed
@joaquim-verges joaquim-verges deleted the Add_thirdweb_branding_to_PayEmbed branch April 18, 2025 00:55
@joaquim-verges joaquim-verges mentioned this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants