Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Apr 18, 2025

TL;DR

Added URL rewrites for Universal Bridge landing pages and Enterprise page.

What changed?

Added two new URL paths to the framer-rewrites.js file:

  • /universal-bridge-regions/:region_slug for region-specific Universal Bridge landing pages
  • /enterprise for the Enterprise page

How to test?

  1. Navigate to /universal-bridge-regions/[any-region-slug] and verify the page loads correctly
  2. Navigate to /enterprise and verify the page loads correctly
  3. Ensure both pages render with the expected content and styling

Why make this change?

These URL paths need to be included in the framer-rewrites to ensure proper routing and rendering of the Universal Bridge landing pages by region and the Enterprise page.


PR-Codex overview

This PR focuses on updating the routing in the framer-rewrites.js file by adding a new path for universal bridge landing pages.

Detailed summary

  • Added a new route for universal bridge landing pages: "/universal-bridge-regions/:region_slug"
  • The new route is added alongside an existing route for the brand kit: "/brand-kit"
  • The route for "/enterprise" remains unchanged.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 18, 2025 07:38 Inactive
@vercel
Copy link

vercel bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 8:13am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 18, 2025 8:13am
login ⬜️ Skipped (Inspect) Apr 18, 2025 8:13am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 18, 2025 8:13am
wallet-ui ⬜️ Skipped (Inspect) Apr 18, 2025 8:13am

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2025

⚠️ No Changeset found

Latest commit: 97ce74f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 18, 2025 07:38 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 18, 2025 07:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 18, 2025 07:38 Inactive
@jnsdls jnsdls marked this pull request as ready for review April 18, 2025 07:38
@jnsdls jnsdls requested review from a team as code owners April 18, 2025 07:38
Copy link
Member Author

jnsdls commented Apr 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 18, 2025
@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.16%. Comparing base (3a43fb2) to head (97ce74f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6763   +/-   ##
=======================================
  Coverage   55.16%   55.16%           
=======================================
  Files         896      896           
  Lines       56910    56910           
  Branches     3938     3938           
=======================================
  Hits        31396    31396           
  Misses      25419    25419           
  Partials       95       95           
Flag Coverage Δ
packages 55.16% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.75 KB (0%) 1.1 s (0%) 166 ms (+147.5% 🔺) 1.2 s
thirdweb (cjs) 138.9 KB (0%) 2.8 s (0%) 291 ms (+59.23% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 66 ms (+1093.42% 🔺) 178 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 35 ms (+1935.8% 🔺) 45 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 102 ms (+657.33% 🔺) 490 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 18, 2025

Merge activity

### TL;DR

Added URL rewrites for Universal Bridge landing pages and Enterprise page.

### What changed?

Added two new URL paths to the framer-rewrites.js file:
- `/universal-bridge-regions/:region_slug` for region-specific Universal Bridge landing pages
- `/enterprise` for the Enterprise page

### How to test?

1. Navigate to `/universal-bridge-regions/[any-region-slug]` and verify the page loads correctly
2. Navigate to `/enterprise` and verify the page loads correctly
3. Ensure both pages render with the expected content and styling

### Why make this change?

These URL paths need to be included in the framer-rewrites to ensure proper routing and rendering of the Universal Bridge landing pages by region and the Enterprise page.
@graphite-app graphite-app bot force-pushed the Add_universal_bridge_landing_pages_to_framer-rewrites branch from e7836ae to 97ce74f Compare April 18, 2025 08:06
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 18, 2025 08:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 18, 2025 08:06 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 18, 2025 08:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 18, 2025 08:06 Inactive
@graphite-app graphite-app bot merged commit 97ce74f into main Apr 18, 2025
23 checks passed
@graphite-app graphite-app bot deleted the Add_universal_bridge_landing_pages_to_framer-rewrites branch April 18, 2025 08:14
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 18, 2025 08:14 Inactive
@vercel vercel bot temporarily deployed to Production – login April 18, 2025 08:14 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 18, 2025 08:14 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 18, 2025 08:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants