-
Notifications
You must be signed in to change notification settings - Fork 621
[SDK] Improve NFT data fallbacks for indexer cache misses #6765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Improve NFT data fallbacks for indexer cache misses #6765
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: e870cad The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (75.55%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6765 +/- ##
=======================================
Coverage 55.16% 55.17%
=======================================
Files 896 896
Lines 56910 56903 -7
Branches 3938 3940 +2
=======================================
Hits 31396 31396
+ Misses 25419 25411 -8
- Partials 95 96 +1
🚀 New features to boost your workflow:
|
size-limit report 📦
|
jnsdls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codecov is unhappy but otherwise LGTM

PR-Codex overview
This PR focuses on enhancing the fallback mechanisms for retrieving NFT data when there are cache misses, ensuring more reliable data retrieval from the
thirdwebecosystem.Detailed summary
THIRDWEB_INSIGHT_API_DOMAINconstant.THIRDWEB_INSIGHT_API_DOMAINin thegetThirdwebClientfunction.getNFTandgetNFTsfunctions to fallback to RPC if NFT data is not found.getNFTs.useIndexerto false in RPC calls for both ERC721 and ERC1155.