Dashboard: Improve Progress bar implmentation with useTransition hook #6769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6769 +/- ##
=======================================
Coverage 55.17% 55.17%
=======================================
Files 896 896
Lines 56921 56921
Branches 3942 3942
=======================================
Hits 31407 31407
Misses 25418 25418
Partials 96 96
🚀 New features to boost your workflow:
|
Contributor
size-limit report 📦
|
MananTank
force-pushed
the
mnn/better-progress-bar
branch
from
dd1ccd0 to
d14be78
Compare
jnsdls
approved these changes
Apr 18, 2025
Contributor
Merge activity
|
…#6769) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR refines the `useDashboardRouter` functionality by implementing a progress bar during route transitions and removing the use of `LoadingRouteHref`. It introduces `RouteStartTransitionFn` for managing transition states and modifies the `DashboardRouterTopProgressBar` to reflect these changes. ### Detailed summary - Removed `usePathname` and `useSearchParams` from `useRouterLoadingStatus`. - Replaced `LoadingRouteHref` with `RouteStartTransitionFn` for managing transition states. - Updated `replace` and `push` methods in `useDashboardRouter` to use `startTransition`. - Refactored `DashboardRouterTopProgressBarInner` to use `isRouteLoading`. - Adjusted progress bar visibility and state management based on `isRouteLoading`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
mnn/better-progress-bar
branch
from
d14be78 to
17b8368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR refines the
useDashboardRouterfunctionality to improve navigation performance by implementing a transition mechanism, replacing the previous loading state management, and enhancing theDashboardRouterTopProgressBarfor better route loading indication.Detailed summary
usePathnameanduseSearchParamsfromuseRouterLoadingStatus.RouteStartTransitionFnto manage transition states.useDashboardRouterto usestartTransitionforrouter.pushandrouter.replace.isLoadingtoisRouteLoadingfor clarity.DashboardRouterTopProgressBarInnerto trackisRouteLoading.Suspensewrapping inDashboardRouterTopProgressBar.