Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Apr 18, 2025

No description provided.

@vercel
Copy link

vercel bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 6:30pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 6:30pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 6:30pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 6:30pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 6:30pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2025

🦋 Changeset detected

Latest commit: 2caf5f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@thirdweb-dev/service-utils Patch
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 18, 2025
Copy link
Member Author

jnsdls commented Apr 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.17%. Comparing base (17b8368) to head (2caf5f3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/utils/fetch.ts 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6771      +/-   ##
==========================================
- Coverage   55.17%   55.17%   -0.01%     
==========================================
  Files         896      896              
  Lines       56921    56924       +3     
  Branches     3942     3942              
==========================================
  Hits        31407    31407              
- Misses      25418    25421       +3     
  Partials       96       96              
Flag Coverage Δ
packages 55.17% <0.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
packages/thirdweb/src/client/client.ts 100.00% <ø> (ø)
packages/thirdweb/src/utils/fetch.ts 82.84% <0.00%> (-1.50%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.71 KB (-0.09% 🔽) 1.1 s (-0.09% 🔽) 260 ms (+145.37% 🔺) 1.3 s
thirdweb (cjs) 138.82 KB (-0.15% 🔽) 2.8 s (-0.15% 🔽) 344 ms (+30.81% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.6 KB (+0.2% 🔺) 113 ms (+0.2% 🔺) 92 ms (+703.61% 🔺) 204 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 55 ms (+2438.79% 🔺) 65 ms
thirdweb/react (minimal + tree-shaking) 19.37 KB (+0.07% 🔺) 388 ms (+0.07% 🔺) 139 ms (+496.65% 🔺) 527 ms

@jnsdls jnsdls merged commit 9d72ddd into main Apr 18, 2025
25 of 26 checks passed
@jnsdls jnsdls deleted the Allow_passing_team_ID_explicitly_via_request_headers branch April 18, 2025 18:33
@joaquim-verges joaquim-verges mentioned this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants