Skip to content

Conversation

@GiselleNessi
Copy link
Contributor

@GiselleNessi GiselleNessi commented Apr 18, 2025


PR-Codex overview

This PR modifies the APIHeader component in APIHeader.tsx by changing the button actions and their associated links. It updates the demo button text and link, while also rearranging the order of the buttons.

Detailed summary

  • Removed the original demo button with the text "Book a Demo" and replaced it with "Add instantly" linked to the dashboard.
  • Retained and repositioned the documentation button, maintaining the same link and icon.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@GiselleNessi GiselleNessi self-assigned this Apr 18, 2025
@GiselleNessi GiselleNessi requested review from a team as code owners April 18, 2025 20:29
@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2025

⚠️ No Changeset found

Latest commit: e867e46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 8:31pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 18, 2025 8:31pm
login ⬜️ Skipped (Inspect) Apr 18, 2025 8:31pm
thirdweb-www ⬜️ Skipped (Inspect) Apr 18, 2025 8:31pm
wallet-ui ⬜️ Skipped (Inspect) Apr 18, 2025 8:31pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Apr 18, 2025
@GiselleNessi GiselleNessi added the merge-queue Adds the pull request to Graphite's merge queue. label Apr 18, 2025
Copy link
Contributor Author

GiselleNessi commented Apr 18, 2025

Merge activity

  • Apr 18, 4:30 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 18, 5:30 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 18, 5:31 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (0c5c918) to head (e867e46).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6774   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files         896      896           
  Lines       56924    56924           
  Branches     3943     3943           
=======================================
  Hits        31412    31412           
  Misses      25416    25416           
  Partials       96       96           
Flag Coverage Δ
packages 55.18% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.71 KB (0%) 1.1 s (0%) 207 ms (+121.06% 🔺) 1.3 s
thirdweb (cjs) 138.82 KB (0%) 2.8 s (0%) 349 ms (+48.87% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 82 ms (+969.99% 🔺) 194 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 38 ms (+844.31% 🔺) 48 ms
thirdweb/react (minimal + tree-shaking) 19.37 KB (0%) 388 ms (0%) 91 ms (+317.22% 🔺) 479 ms

@gregfromstl gregfromstl merged commit f7f179c into main Apr 18, 2025
24 checks passed
@gregfromstl gregfromstl deleted the gi/playground-cta-updates branch April 18, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants