Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Apr 21, 2025

Added engineCloud plan capability to the TeamCapabilities type in the service-utils package. This includes properties for enabled status, mainnet enablement, and rate limiting. Also updated the mock validTeamResponse to include the new engineCloud capability with sample values.


PR-Codex overview

This PR introduces an engineCloud plan capability across multiple files, enhancing functionality with specific properties such as enabled, mainnetEnabled, and rateLimit.

Detailed summary

  • Added engineCloud configuration with properties enabled, rateLimit, and mainnetEnabled in:
    • apps/dashboard/src/stories/stubs.ts
    • packages/service-utils/src/mocks.ts
    • packages/service-utils/src/core/api.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 10:38pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 10:38pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 10:38pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 10:38pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 10:38pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2025

🦋 Changeset detected

Latest commit: 4f2c10a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jnsdls jnsdls marked this pull request as ready for review April 21, 2025 20:35
@jnsdls jnsdls requested a review from a team as a code owner April 21, 2025 20:35
Copy link
Member Author

jnsdls commented Apr 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (d7dc83f) to head (4f2c10a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6793   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files         896      896           
  Lines       56934    56934           
  Branches     3944     3944           
=======================================
  Hits        31420    31420           
  Misses      25418    25418           
  Partials       96       96           
Flag Coverage Δ
packages 55.18% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.73 KB (0%) 1.1 s (0%) 183 ms (+158.48% 🔺) 1.2 s
thirdweb (cjs) 138.79 KB (0%) 2.8 s (0%) 289 ms (+83.52% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 126 ms (+2352.6% 🔺) 238 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 97 ms (+6289.87% 🔺) 107 ms
thirdweb/react (minimal + tree-shaking) 19.41 KB (0%) 389 ms (0%) 104 ms (+691.45% 🔺) 492 ms

@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Apr 21, 2025 — with Graphite App
@jnsdls jnsdls force-pushed the Add_engineCloud_plan_capability_to_service-utils branch from 15332be to 4f2c10a Compare April 21, 2025 20:45
@jnsdls jnsdls requested a review from a team as a code owner April 21, 2025 20:45
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 21, 2025
@jnsdls jnsdls removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Apr 21, 2025
@jnsdls jnsdls merged commit f85163e into main Apr 22, 2025
24 checks passed
@jnsdls jnsdls deleted the Add_engineCloud_plan_capability_to_service-utils branch April 22, 2025 09:43
@joaquim-verges joaquim-verges mentioned this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants