Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 22, 2025

Big changes:

  • move nebula-app folder outside the app layout so it can have its own theme, autoConnect behavior, context providers etc - to do this, we had to move all existing files inside a new (app) folder
  • connect to smart wallet in nebula by default

@linear
Copy link

linear bot commented Apr 22, 2025

@vercel
Copy link

vercel bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 11:24pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 22, 2025 11:24pm
login ⬜️ Skipped (Inspect) Apr 22, 2025 11:24pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 22, 2025 11:24pm
wallet-ui ⬜️ Skipped (Inspect) Apr 22, 2025 11:24pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 22, 2025 20:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 22, 2025 20:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 22, 2025 20:09 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 22, 2025 20:09 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2025

⚠️ No Changeset found

Latest commit: b730ab1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 22, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (21cc01a) to head (1a1eb61).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6816   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files         896      896           
  Lines       56940    56939    -1     
  Branches     3943     3943           
=======================================
  Hits        31420    31420           
+ Misses      25424    25423    -1     
  Partials       96       96           
Flag Coverage Δ
packages 55.18% <ø> (+<0.01%) ⬆️

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MananTank MananTank marked this pull request as ready for review April 22, 2025 20:10
@MananTank MananTank requested review from a team as code owners April 22, 2025 20:10
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 22, 2025 20:12 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 22, 2025 20:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 22, 2025 20:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 22, 2025 20:12 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.73 KB (0%) 1.1 s (0%) 149 ms (+130.4% 🔺) 1.2 s
thirdweb (cjs) 138.79 KB (0%) 2.8 s (0%) 266 ms (+51.44% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 75 ms (+1336.11% 🔺) 187 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 38 ms (+2184.9% 🔺) 48 ms
thirdweb/react (minimal + tree-shaking) 19.41 KB (0%) 389 ms (0%) 99 ms (+690.99% 🔺) 487 ms

@MananTank MananTank changed the title [NEB-6814] Move Nebula outside of app layout, connect to smart wallet by default [NEB-6814] Nebula: move outside of app layout, connect to smart wallet on login Apr 22, 2025
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 22, 2025 20:52 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 22, 2025 20:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 22, 2025 20:52 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 22, 2025 20:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 22, 2025 20:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 22, 2025 21:41 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 22, 2025 21:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 22, 2025 21:41 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 22, 2025 21:41 Inactive
@MananTank MananTank changed the title [NEB-6814] Nebula: move outside of app layout, connect to smart wallet on login [NEB-6814] Nebula: move outside of app layout, connect to smart wallet on login Apr 22, 2025
@MananTank MananTank changed the title [NEB-6814] Nebula: move outside of app layout, connect to smart wallet on login [NEB-6814] Nebula: move outside of app layout, connect to smart wallet on login - DO NOT MERGE, WAITING FOR PROD CHANGES Apr 22, 2025
@MananTank MananTank marked this pull request as draft April 22, 2025 22:34
@MananTank MananTank changed the title [NEB-6814] Nebula: move outside of app layout, connect to smart wallet on login - DO NOT MERGE, WAITING FOR PROD CHANGES [NEB-6814] Nebula: move outside of app layout, connect to smart wallet on login Apr 22, 2025
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 22, 2025 22:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 22, 2025 22:47 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 22, 2025 22:47 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 22, 2025 22:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 22, 2025 23:18 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 22, 2025 23:18 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 22, 2025 23:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 22, 2025 23:18 Inactive
@jakeloo jakeloo marked this pull request as ready for review April 22, 2025 23:28
@jakeloo jakeloo enabled auto-merge (squash) April 22, 2025 23:29
@jnsdls jnsdls disabled auto-merge April 22, 2025 23:33
@jnsdls jnsdls merged commit 67a7d3e into main Apr 22, 2025
20 of 21 checks passed
@jnsdls jnsdls deleted the neb-187 branch April 22, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants