Skip to content

Dashboard: transfer tab disabled for owner of nft #6827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Dashboard: transfer tab disabled for owner of nft #6827

merged 1 commit into from
Apr 23, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 23, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR enhances the useNFTDrawerTabs function by adding address checksum validation when comparing the NFT owner with the account address, ensuring accurate ownership checks.

Detailed summary

  • Added import for checksumAddress from thirdweb/utils.
  • Modified the owner check for ERC721 NFTs to include checksum validation for both the NFT owner and the account address.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4baefa5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 23, 2025 13:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 23, 2025 13:13 Inactive
@vercel
Copy link

vercel bot commented Apr 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 1:29pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 23, 2025 1:29pm
login ⬜️ Skipped (Inspect) Apr 23, 2025 1:29pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 23, 2025 1:29pm
wallet-ui ⬜️ Skipped (Inspect) Apr 23, 2025 1:29pm

@vercel vercel bot temporarily deployed to Preview – login April 23, 2025 13:13 Inactive
@MananTank MananTank marked this pull request as ready for review April 23, 2025 13:13
@MananTank MananTank requested review from a team as code owners April 23, 2025 13:13
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 23, 2025 13:13 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 23, 2025
@MananTank Graphite App
Copy link
Member Author

MananTank commented Apr 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title Dashboard: Quick fix transfer tab disabled for owner of nft Dashboard: transfer tab disabled for owner of nft Apr 23, 2025
@codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (b2e56f8) to head (4baefa5).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6827   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files         896      896           
  Lines       56953    56953           
  Branches     3946     3946           
=======================================
  Hits        31429    31429           
  Misses      25428    25428           
  Partials       96       96
Flag Coverage Δ
packages 55.18% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.92 KB (0%) 1.1 s (0%) 270 ms (+141.71% 🔺) 1.3 s
thirdweb (cjs) 143.74 KB (0%) 2.9 s (0%) 459 ms (+63.49% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 82 ms (+1088.51% 🔺) 195 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 55 ms (+2031.91% 🔺) 65 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 103 ms (+451.32% 🔺) 489 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 23, 2025 •
edited
Loading

Merge activity

@MananTank
Dashboard: transfer tab disabled for owner of nft (#6827)
4baefa5 
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `useNFTDrawerTabs` function by improving the owner address comparison for NFTs. It now uses the `checksumAddress` utility to ensure that both the NFT owner and the account address are valid checksummed addresses before comparing them.

### Detailed summary
- Added import for `checksumAddress` from `thirdweb/utils`.
- Updated the owner address comparison in the `useNFTDrawerTabs` function to use `checksumAddress`.
- Ensured that both `accountAddress` and `nft.owner` are checked for validity before comparison.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-23-dashboard_quick_fix_transfer_tab_disabled_for_owner_of_nft branch from 8531508 to 4baefa5 Compare April 23, 2025 13:20
@graphite-app graphite-app bot merged commit 4baefa5 into main Apr 23, 2025
23 checks passed
@graphite-app graphite-app bot deleted the 04-23-dashboard_quick_fix_transfer_tab_disabled_for_owner_of_nft branch April 23, 2025 13:29
@vercel vercel bot temporarily deployed to Production – docs-v2 April 23, 2025 13:30 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 23, 2025 13:30 Inactive
@vercel vercel bot temporarily deployed to Production – login April 23, 2025 13:30 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 23, 2025 13:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls